The CSS WG has resolved to restrict the overflow-alignment syntax to avoid ambiguities when used in the place-xx shorthand. https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434 Due to this decision, the new CSS syntax impose that the 'overflow' keyword must precede the 'self-position' or 'left' or 'right' keywords.
Created attachment 331619 [details] Patch
Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6121058 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html
Created attachment 331622 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6121063 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html
Created attachment 331623 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6121096 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html
Created attachment 331625 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6121103 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html
Created attachment 331626 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6121301 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html css3/overwrite-content-alignment.html
Created attachment 331629 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 331656 [details] Patch
Comment on attachment 331656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331656&action=review > Source/WebCore/ChangeLog:14 > + There were several discussions to avoid ambiguities with the complex > + values, specially when it comes to define the place-xxx shorthands. > + > + One of the sources of problems is the 'overflow-position' keyword. The > + CSS WG has decided to change the syntax of all the CSS Box Alignment > + properties so that the 'overflow-position' keyword always precede the > + 'self-position' or the 'content-position' keywords. It would be good to explain in the ChangeLog why these changes are not expected to be content breaking. They do require fixes to many LayoutTests.
r=me
Created attachment 331904 [details] Patch
Comment on attachment 331904 [details] Patch Clearing flags on attachment: 331904 Committed r227297: <https://trac.webkit.org/changeset/227297>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36735686>