Bug 181793 - [css-align] 'overflow' keyword must precede the self-position and content-position value
Summary: [css-align] 'overflow' keyword must precede the self-position and content-pos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-18 04:31 PST by Javier Fernandez
Modified: 2018-01-23 06:14 PST (History)
8 users (show)

See Also:


Attachments
Patch (76.45 KB, patch)
2018-01-18 07:16 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.33 MB, application/zip)
2018-01-18 08:18 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.84 MB, application/zip)
2018-01-18 08:22 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews112 for mac-sierra (2.97 MB, application/zip)
2018-01-18 08:42 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.22 MB, application/zip)
2018-01-18 08:47 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews206 for win-future (12.07 MB, application/zip)
2018-01-18 09:08 PST, EWS Watchlist
no flags Details
Patch (88.11 KB, patch)
2018-01-18 13:45 PST, Javier Fernandez
jfernandez: commit-queue+
Details | Formatted Diff | Diff
Patch (88.64 KB, patch)
2018-01-22 02:00 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2018-01-18 04:31:39 PST
The CSS WG has resolved to restrict the overflow-alignment syntax to avoid ambiguities when used in the place-xx shorthand. 

https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434

Due to this decision, the new CSS syntax impose that the 'overflow' keyword must precede the 'self-position' or 'left' or 'right' keywords.
Comment 1 Javier Fernandez 2018-01-18 07:16:29 PST
Created attachment 331619 [details]
Patch
Comment 2 EWS Watchlist 2018-01-18 08:18:11 PST
Comment on attachment 331619 [details]
Patch

Attachment 331619 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6121058

New failing tests:
css3/overwrite-self-alignment.html
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
fast/css-grid-layout/grid-content-alignment-overflow.html
css3/overwrite-content-alignment.html
fast/css-grid-layout/grid-align-justify-overflow.html
Comment 3 EWS Watchlist 2018-01-18 08:18:12 PST
Created attachment 331622 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-01-18 08:22:20 PST
Comment on attachment 331619 [details]
Patch

Attachment 331619 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6121063

New failing tests:
css3/overwrite-self-alignment.html
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
fast/css-grid-layout/grid-content-alignment-overflow.html
css3/overwrite-content-alignment.html
fast/css-grid-layout/grid-align-justify-overflow.html
Comment 5 EWS Watchlist 2018-01-18 08:22:22 PST
Created attachment 331623 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-01-18 08:42:53 PST
Comment on attachment 331619 [details]
Patch

Attachment 331619 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6121096

New failing tests:
css3/overwrite-self-alignment.html
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
fast/css-grid-layout/grid-content-alignment-overflow.html
css3/overwrite-content-alignment.html
fast/css-grid-layout/grid-align-justify-overflow.html
Comment 7 EWS Watchlist 2018-01-18 08:42:54 PST
Created attachment 331625 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-01-18 08:47:07 PST
Comment on attachment 331619 [details]
Patch

Attachment 331619 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6121103

New failing tests:
css3/overwrite-self-alignment.html
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
fast/css-grid-layout/grid-content-alignment-overflow.html
css3/overwrite-content-alignment.html
fast/css-grid-layout/grid-align-justify-overflow.html
Comment 9 EWS Watchlist 2018-01-18 08:47:09 PST
Created attachment 331626 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-01-18 09:08:01 PST
Comment on attachment 331619 [details]
Patch

Attachment 331619 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6121301

New failing tests:
css3/overwrite-self-alignment.html
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html
css3/overwrite-content-alignment.html
Comment 11 EWS Watchlist 2018-01-18 09:08:12 PST
Created attachment 331629 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 12 Javier Fernandez 2018-01-18 13:45:24 PST
Created attachment 331656 [details]
Patch
Comment 13 Antti Koivisto 2018-01-22 00:38:35 PST
Comment on attachment 331656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331656&action=review

> Source/WebCore/ChangeLog:14
> +        There were several discussions to avoid ambiguities with the complex
> +        values, specially when it comes to define the place-xxx shorthands.
> +
> +        One of the sources of problems is the 'overflow-position' keyword. The
> +        CSS WG has decided to change the syntax of all the CSS Box Alignment
> +        properties so that the 'overflow-position' keyword always precede the
> +        'self-position' or the 'content-position' keywords.

It would be good to explain in the ChangeLog why these changes are not expected to be content breaking. They do require fixes to many LayoutTests.
Comment 14 Antti Koivisto 2018-01-22 00:41:04 PST
r=me
Comment 15 Javier Fernandez 2018-01-22 02:00:04 PST
Created attachment 331904 [details]
Patch
Comment 16 WebKit Commit Bot 2018-01-22 09:01:56 PST
Comment on attachment 331904 [details]
Patch

Clearing flags on attachment: 331904

Committed r227297: <https://trac.webkit.org/changeset/227297>
Comment 17 WebKit Commit Bot 2018-01-22 09:01:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 18 Radar WebKit Bug Importer 2018-01-22 09:04:36 PST
<rdar://problem/36735686>