RESOLVED FIXED 181786
Don't fetch more than two builds to check duplicity of builds in ReportProcessor 
https://bugs.webkit.org/show_bug.cgi?id=181786
Summary Don't fetch more than two builds to check duplicity of builds in ReportProcessor
Ryosuke Niwa
Reported 2018-01-17 22:57:10 PST
Right now, ReportProcessor::resolve_build_id fetches all builds that match the builder number and time. This can result in a long delay & a high memory usage.
Attachments
Fixes the bug (1.74 KB, patch)
2018-01-17 23:00 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-01-17 23:00:26 PST
Created attachment 331600 [details] Fixes the bug
Wenson Hsieh
Comment 2 2018-01-18 14:55:29 PST
Comment on attachment 331600 [details] Fixes the bug rs=me. I'm a bit curious why the maximum limit of 2 builds is hard-coded. Is this hardware-dependent, and "2" is the most reasonable cap for our machines we're using to run the perf dashboard? It seems like maybe it should be configurable, but I'm not familiar with this code at all :P
Ryosuke Niwa
Comment 3 2018-01-18 15:01:47 PST
Comment on attachment 331600 [details] Fixes the bug Clearing flags on attachment: 331600 Committed r227166: <https://trac.webkit.org/changeset/227166>
Ryosuke Niwa
Comment 4 2018-01-18 15:01:49 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2018-01-18 15:01:54 PST
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 331600 [details] > Fixes the bug > > rs=me. > > I'm a bit curious why the maximum limit of 2 builds is hard-coded. Is this > hardware-dependent, and "2" is the most reasonable cap for our machines > we're using to run the perf dashboard? It seems like maybe it should be > configurable, but I'm not familiar with this code at all :P It's two because we're trying to check that it's unique. When there are more than two entries, we know there is at least one duplicate. We don't need to fetch all the duplicates to know that there are some duplicate.
Radar WebKit Bug Importer
Comment 6 2018-01-18 15:02:50 PST
<rdar://problem/36635350>
Note You need to log in before you can comment on or make changes to this bug.