Bug 181782 - Fix perf dashboard tests for node v8
Summary: Fix perf dashboard tests for node v8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-17 21:42 PST by Ryosuke Niwa
Modified: 2018-01-17 22:14 PST (History)
6 users (show)

See Also:

Attachments
Fixes the tests (deleted)
2018-01-17 21:50 PST, Ryosuke Niwa 		no flags Details
Fixes the tests (7.93 KB, patch)
2018-01-17 21:55 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-01-17 21:42:12 PST 
There are some test failures in the latest LTS of node.js.
Fix them all.
Comment 1 Ryosuke Niwa 2018-01-17 21:50:59 PST 
Created attachment 331592 [details]
Fixes the tests
Comment 2 Lucas Forschler 2018-01-17 21:54:11 PST 
The content of attachment 331592 [details] has been deleted for the following reason:

incorrect
Comment 3 Ryosuke Niwa 2018-01-17 21:55:18 PST 
Created attachment 331593 [details]
Fixes the tests
Comment 4 Wenson Hsieh 2018-01-17 21:59:07 PST 
Comment on attachment 331593 [details]
Fixes the tests

rs=me
Comment 5 Ryosuke Niwa 2018-01-17 22:06:51 PST 
Comment on attachment 331593 [details]
Fixes the tests

Clearing flags on attachment: 331593

Committed r227122: <https://trac.webkit.org/changeset/227122>
Comment 6 Ryosuke Niwa 2018-01-17 22:06:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-17 22:14:42 PST 
<rdar://problem/36608851>