Bug 181774 - clean up pushToSaveImmediateWithoutTouchingRegisters a bit
Summary: clean up pushToSaveImmediateWithoutTouchingRegisters a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-17 18:07 PST by Saam Barati
Modified: 2018-01-31 02:06 PST (History)
13 users (show)

See Also:

Attachments
patch (1.77 KB, patch)
2018-01-17 18:15 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (1.89 KB, patch)
2018-01-17 18:49 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (2.00 KB, patch)
2018-01-18 18:18 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-01-17 18:07:23 PST 
...
Comment 1 Saam Barati 2018-01-17 18:15:58 PST 
Created attachment 331570 [details]
patch
Comment 2 Saam Barati 2018-01-17 18:49:39 PST 
Created attachment 331576 [details]
patch
Comment 3 Saam Barati 2018-01-18 18:18:51 PST 
Created attachment 331686 [details]
patch
Comment 4 Saam Barati 2018-01-18 18:19:13 PST 
(In reply to Saam Barati from comment #3)
> Created attachment 331686 [details]
> patch

Updated to using dataTempRegister.
Comment 5 Saam Barati 2018-01-30 20:19:30 PST 
ping
Comment 6 JF Bastien 2018-01-30 21:03:44 PST 
Comment on attachment 331686 [details]
patch

r=me

Since the register doesn't matter it could totally be random... Though I guess it might lead to different GC values getting spilled sometimes? In that case data temp being on the stack is probably better than others.
Comment 7 Saam Barati 2018-01-30 21:38:32 PST 
(In reply to JF Bastien from comment #6)
> Comment on attachment 331686 [details]
> patch
> 
> r=me
> 
> Since the register doesn't matter it could totally be random... Though I
> guess it might lead to different GC values getting spilled sometimes? In
> that case data temp being on the stack is probably better than others.

Yeah it totally could be as long as it’s not a HW reserved register. An earlier incarnation of this patch chose x9 or x19 or something like that
Comment 8 WebKit Commit Bot 2018-01-31 02:05:02 PST 
Comment on attachment 331686 [details]
patch

Clearing flags on attachment: 331686

Committed r227897: <https://trac.webkit.org/changeset/227897>
Comment 9 WebKit Commit Bot 2018-01-31 02:05:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-01-31 02:06:27 PST 
<rdar://problem/37062583>