RESOLVED FIXED181768
[Curl] Use ResourceRequest::encodeWithPlatformData() 
https://bugs.webkit.org/show_bug.cgi?id=181768
Summary [Curl] Use ResourceRequest::encodeWithPlatformData()
Stephan Szabo
Reported 2018-01-17 15:06:49 PST
encodeWithoutPlatformData() should not be called from encodePlatformData(), which results in assertion failures. Instead we should make and use an encodeWithPlatformData().
Attachments
Do not call encodeWithoutPlatformData() from encodePlatformData() (4.00 KB, patch)
2018-01-17 15:33 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog (4.00 KB, patch)
2018-01-17 15:39 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2018-01-17 15:33:46 PST
Created attachment 331547 [details] Do not call encodeWithoutPlatformData() from encodePlatformData()
EWS Watchlist
Comment 2 2018-01-17 15:35:49 PST
Attachment 331547 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Stephan Szabo
Comment 3 2018-01-17 15:39:19 PST
Created attachment 331548 [details] Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog
WebKit Commit Bot
Comment 4 2018-01-17 16:26:36 PST
Comment on attachment 331548 [details] Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog Clearing flags on attachment: 331548 Committed r227095: <https://trac.webkit.org/changeset/227095>
WebKit Commit Bot
Comment 5 2018-01-17 16:26:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-17 16:27:28 PST
<rdar://problem/36600584>
Note You need to log in before you can comment on or make changes to this bug.