Bug 181768 - [Curl] Use ResourceRequest::encodeWithPlatformData()
Summary: [Curl] Use ResourceRequest::encodeWithPlatformData()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-17 15:06 PST by Stephan Szabo
Modified: 2018-01-17 16:27 PST (History)
9 users (show)

See Also:

Attachments
Do not call encodeWithoutPlatformData() from encodePlatformData() (4.00 KB, patch)
2018-01-17 15:33 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog (4.00 KB, patch)
2018-01-17 15:39 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-01-17 15:06:49 PST 
encodeWithoutPlatformData() should not be called from encodePlatformData(), which results in assertion failures.
Instead we should make and use an encodeWithPlatformData().
Comment 1 Stephan Szabo 2018-01-17 15:33:46 PST 
Created attachment 331547 [details]
Do not call encodeWithoutPlatformData() from encodePlatformData()
Comment 2 EWS Watchlist 2018-01-17 15:35:49 PST 
Attachment 331547 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Stephan Szabo 2018-01-17 15:39:19 PST 
Created attachment 331548 [details]
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog
Comment 4 WebKit Commit Bot 2018-01-17 16:26:36 PST 
Comment on attachment 331548 [details]
Do not call encodeWithoutPlatformData() from encodePlatformData() - fixed changelog

Clearing flags on attachment: 331548

Committed r227095: <https://trac.webkit.org/changeset/227095>
Comment 5 WebKit Commit Bot 2018-01-17 16:26:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-17 16:27:28 PST 
<rdar://problem/36600584>