Bug 181762 - Multicol: RenderMultiColumnFlow should not inherit the flow state
Summary: Multicol: RenderMultiColumnFlow should not inherit the flow state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-17 13:30 PST by zalan
Modified: 2018-01-17 14:37 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.74 KB, patch)
2018-01-17 13:34 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (3.74 KB, patch)
2018-01-17 14:10 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-17 13:30:47 PST
when we compute it ::computedFragmentedFlowState() as the result of a style change. RenderMultiColumnFlow, by definition is InsideInFragmentedFlow.
Comment 1 zalan 2018-01-17 13:31:11 PST
<rdar://problem/35448565>
Comment 2 zalan 2018-01-17 13:34:15 PST
Created attachment 331536 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-01-17 13:55:13 PST
Comment on attachment 331536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331536&action=review

> Source/WebCore/ChangeLog:9
> +        Do not computed the inherited flow state flag for RenderMultiColumnFlow.

compute
Comment 4 zalan 2018-01-17 14:10:11 PST
Created attachment 331539 [details]
Patch
Comment 5 WebKit Commit Bot 2018-01-17 14:37:27 PST
Comment on attachment 331539 [details]
Patch

Clearing flags on attachment: 331539

Committed r227087: <https://trac.webkit.org/changeset/227087>
Comment 6 WebKit Commit Bot 2018-01-17 14:37:29 PST
All reviewed patches have been landed.  Closing bug.