Bug 181751 - [GTK] Try even harder not to static link WTF into libwebkit2gtk
Summary: [GTK] Try even harder not to static link WTF into libwebkit2gtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-17 11:19 PST by Michael Catanzaro
Modified: 2018-01-17 15:16 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2018-01-17 11:21 PST, Michael Catanzaro 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-01-17 11:19:23 PST 
Try even harder not to static link WTF into libwebkit2gtk. We don't want two copies of WTF. It should only be in libjavascriptcoregtk.

Yesterday I found it was being linked into PAL. Today I noticed it's being linked directly into WebCore as well. Build systems are full of landmines.
Comment 1 Michael Catanzaro 2018-01-17 11:20:01 PST 
When we have this fully solved, then I *think* we should be able to turn on -fvisibility=hidden and -fvisibility-inlines=hidden again.
Comment 2 Michael Catanzaro 2018-01-17 11:21:08 PST 
Created attachment 331524 [details]
Patch
Comment 3 Michael Catanzaro 2018-01-17 11:22:58 PST 
(In reply to Michael Catanzaro from comment #0)
> Build systems are full of landmines.

An interesting property of CMake build systems is that so long as anyone other than Konstantin is allowed to touch the build files, it will never work entirely as intended.

I think I'm making some forward progress here, but perhaps I'm delusional....
Comment 4 Michael Catanzaro 2018-01-17 15:16:32 PST 
Committed r227089: <https://trac.webkit.org/changeset/227089>