After r224780, text stroke is no longer visible when rendering video subtitles.
Created attachment 331498 [details] Patch
Attachment 331498 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 331503 [details] Patch
<rdar://problem/35874338>
Created attachment 331513 [details] Patch
Comment on attachment 331513 [details] Patch Can you make a test that checks that video captions have the correct stroke? If we'd had one, we would have detected this regression.
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 331513 [details] > Patch > > Can you make a test that checks that video captions have the correct stroke? > If we'd had one, we would have detected this regression. I will look into that. Thanks for reviewing, Simon!
Created attachment 331561 [details] Patch
Comment on attachment 331561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331561&action=review r=me but please make sure the tests pass. > LayoutTests/media/track/track-css-visible-stroke-expected.html:4 > + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> Is this necessary? > LayoutTests/media/track/track-css-visible-stroke-expected.html:16 > + > + </style> > + You can remove these blank lines. > LayoutTests/media/track/track-css-visible-stroke.html:19 > + background-color: white; I've been using gray for the color (to make their role more clear). > LayoutTests/media/track/track-css-visible-stroke.html:33 > + consoleWrite("Test that style to all cues is applied correctly."); This isn't testing "style to all cues", but just stroke-color.
(In reply to Simon Fraser (smfr) from comment #9) > Comment on attachment 331561 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=331561&action=review > > r=me but please make sure the tests pass. > > > LayoutTests/media/track/track-css-visible-stroke-expected.html:4 > > + <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> > > Is this necessary? > > > LayoutTests/media/track/track-css-visible-stroke-expected.html:16 > > + > > + </style> > > + > > You can remove these blank lines. > > > LayoutTests/media/track/track-css-visible-stroke.html:19 > > + background-color: white; > > I've been using gray for the color (to make their role more clear). > > > LayoutTests/media/track/track-css-visible-stroke.html:33 > > + consoleWrite("Test that style to all cues is applied correctly."); > > This isn't testing "style to all cues", but just stroke-color. Thanks for reviewing!
Committed r227141: <https://trac.webkit.org/changeset/227141/webkit>.