Bug 181738 - WebDriver: ignore the driver in selenium test names when getting expectations
Summary: WebDriver: ignore the driver in selenium test names when getting expectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-17 06:06 PST by Carlos Garcia Campos
Modified: 2018-01-17 22:52 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.92 KB, patch)
2018-01-17 06:14 PST, Carlos Garcia Campos
clopez: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-sierra (2.91 MB, application/zip)
2018-01-17 10:04 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-01-17 06:06:11 PST
In selenium tests, the driver is added as a parameter to every test which results in tests names like foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the driver name in the test expectations file, so we need to remove it when querying the expectations.
Comment 1 Carlos Garcia Campos 2018-01-17 06:14:48 PST
Created attachment 331488 [details]
Patch
Comment 2 EWS Watchlist 2018-01-17 10:04:34 PST
Comment on attachment 331488 [details]
Patch

Attachment 331488 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6106500

New failing tests:
fast/parser/xml-error-adopted.xml
Comment 3 EWS Watchlist 2018-01-17 10:04:35 PST
Created attachment 331508 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Carlos Garcia Campos 2018-01-17 22:51:42 PST
Committed r227127: <https://trac.webkit.org/changeset/227127>