[Cairo] Use one-time ShadowBlur objects when performing shadowing
Created attachment 331471 [details] Patch
Comment on attachment 331471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331471&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:188 > + ShadowBlur shadow(FloatSize { shadowState.blur, shadowState.blur }, Do you really need to use FloatSize explicitly? > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:472 > +bool ShadowState::shadowVisible() const shadow is redundant in method name, I would use isVisible > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:477 > +bool ShadowState::shadowRequired(PlatformContextCairo& platformContext) const Ditto. > Source/WebCore/platform/graphics/cairo/CairoOperations.h:116 > + float blur; Why did you remove the initialization here?
Comment on attachment 331471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331471&action=review >> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:188 >> + ShadowBlur shadow(FloatSize { shadowState.blur, shadowState.blur }, > > Do you really need to use FloatSize explicitly? No, I can change it to use braces. >> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:472 >> +bool ShadowState::shadowVisible() const > > shadow is redundant in method name, I would use isVisible OK. >> Source/WebCore/platform/graphics/cairo/CairoOperations.h:116 >> + float blur; > > Why did you remove the initialization here? Mistake.
Created attachment 331475 [details] Patch for landing
Comment on attachment 331475 [details] Patch for landing Clearing flags on attachment: 331475 Committed r227051: <https://trac.webkit.org/changeset/227051>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36576268>