WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181720
[Cairo] Use one-time ShadowBlur objects when performing shadowing
https://bugs.webkit.org/show_bug.cgi?id=181720
Summary
[Cairo] Use one-time ShadowBlur objects when performing shadowing
Zan Dobersek
Reported
2018-01-16 23:02:46 PST
[Cairo] Use one-time ShadowBlur objects when performing shadowing
Attachments
Patch
(39.26 KB, patch)
2018-01-16 23:15 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch for landing
(39.11 KB, patch)
2018-01-17 01:19 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2018-01-16 23:15:06 PST
Created
attachment 331471
[details]
Patch
Carlos Garcia Campos
Comment 2
2018-01-17 00:54:21 PST
Comment on
attachment 331471
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=331471&action=review
> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:188 > + ShadowBlur shadow(FloatSize { shadowState.blur, shadowState.blur },
Do you really need to use FloatSize explicitly?
> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:472 > +bool ShadowState::shadowVisible() const
shadow is redundant in method name, I would use isVisible
> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:477 > +bool ShadowState::shadowRequired(PlatformContextCairo& platformContext) const
Ditto.
> Source/WebCore/platform/graphics/cairo/CairoOperations.h:116 > + float blur;
Why did you remove the initialization here?
Zan Dobersek
Comment 3
2018-01-17 01:17:47 PST
Comment on
attachment 331471
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=331471&action=review
>> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:188 >> + ShadowBlur shadow(FloatSize { shadowState.blur, shadowState.blur }, > > Do you really need to use FloatSize explicitly?
No, I can change it to use braces.
>> Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:472 >> +bool ShadowState::shadowVisible() const > > shadow is redundant in method name, I would use isVisible
OK.
>> Source/WebCore/platform/graphics/cairo/CairoOperations.h:116 >> + float blur; > > Why did you remove the initialization here?
Mistake.
Zan Dobersek
Comment 4
2018-01-17 01:19:38 PST
Created
attachment 331475
[details]
Patch for landing
Zan Dobersek
Comment 5
2018-01-17 01:20:57 PST
Comment on
attachment 331475
[details]
Patch for landing Clearing flags on attachment: 331475 Committed
r227051
: <
https://trac.webkit.org/changeset/227051
>
Zan Dobersek
Comment 6
2018-01-17 01:21:01 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-01-17 01:21:31 PST
<
rdar://problem/36576268
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug