Right now, input and textarea elements manually invokes FrameSelection::revealSelection. Use FrameSelection::setSelection to reveal selection instead.
<rdar://problem/36570546>
Created attachment 331465 [details] Cleanup
Thanks for the review. Waiting for EWS first.
Comment on attachment 331465 [details] Cleanup Is there any behavior change here?
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 331465 [details] > Cleanup > > Is there any behavior change here? I don't think there is any.
Comment on attachment 331465 [details] Cleanup Clearing flags on attachment: 331465 Committed r227092: <https://trac.webkit.org/changeset/227092>
All reviewed patches have been landed. Closing bug.
(In reply to Ryosuke Niwa from comment #5) > (In reply to Simon Fraser (smfr) from comment #4) > > Comment on attachment 331465 [details] > > Cleanup > > > > Is there any behavior change here? > > I don't think there is any. This broke two tests in wkgtk, but I haven't had time to investigate yet. http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Ftextarea-scrolled-type.html%20fast%2Fforms%2Ffocus-selection-textarea.html
Also this one: editing/input/reveal-edit-on-paste-vertically.html
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r227193%20(5131)/editing/input/reveal-edit-on-paste-vertically-pretty-diff.html -ScrollVertically: PASS +ScrollVertically: FAIL +viewportMiddle: 300, offsetOfInput: 9 https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r227193%20(5131)/fast/forms/focus-selection-textarea-pretty-diff.html Diff a bit long, but this should give a clue: -PASS fourth.selectionStart is 0 -PASS fourth.selectionEnd is 0 +FAIL fourth.selectionStart should be 0. Was 11. +FAIL fourth.selectionEnd should be 0. Was 18. The third one might be related, but it could as well just be that an updated expectation for gtk+ is needed. Hope the above is useful!
You might need to wait until the scrolling happens because the scrolling is now happens after the layout asynchronously.
(In reply to Ryosuke Niwa from comment #11) > You might need to wait until the scrolling happens because the scrolling is > now happens after the layout asynchronously. Where do you mean? In the EventSenderProxy?
(In reply to Claudio Saavedra from comment #12) > (In reply to Ryosuke Niwa from comment #11) > > You might need to wait until the scrolling happens because the scrolling is > > now happens after the layout asynchronously. > > Where do you mean? In the EventSenderProxy? In those tests.