WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181713
Page.cpp only sees forward declaration of ApplicationStateChangeListener when ENABLE(VIDEO) is off
https://bugs.webkit.org/show_bug.cgi?id=181713
Summary
Page.cpp only sees forward declaration of ApplicationStateChangeListener when...
Stephan Szabo
Reported
2018-01-16 18:00:57 PST
The changes in
https://bugs.webkit.org/show_bug.cgi?id=181623
to Page.cpp appear to fail when ENABLE(VIDEO) is off. With ENABLE(VIDEO), HTMLMediaElement.h will #include "ApplicationStateChangeListener.h", but without it, Page.cpp appears to only get the forward declaration from Document.h.
Attachments
Add #include for ApplicationStateChangeListener
(1.17 KB, patch)
2018-01-16 18:03 PST
,
Stephan Szabo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Stephan Szabo
Comment 1
2018-01-16 18:03:30 PST
Created
attachment 331444
[details]
Add #include for ApplicationStateChangeListener
WebKit Commit Bot
Comment 2
2018-01-17 09:36:23 PST
Comment on
attachment 331444
[details]
Add #include for ApplicationStateChangeListener Clearing flags on attachment: 331444 Committed
r227069
: <
https://trac.webkit.org/changeset/227069
>
WebKit Commit Bot
Comment 3
2018-01-17 09:36:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2018-01-17 09:38:28 PST
<
rdar://problem/36585921
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug