Bug 181713 - Page.cpp only sees forward declaration of ApplicationStateChangeListener when ENABLE(VIDEO) is off
Summary: Page.cpp only sees forward declaration of ApplicationStateChangeListener when...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-16 18:00 PST by Stephan Szabo
Modified: 2018-01-17 09:38 PST (History)
6 users (show)

See Also:

Attachments
Add #include for ApplicationStateChangeListener (1.17 KB, patch)
2018-01-16 18:03 PST, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2018-01-16 18:00:57 PST 
The changes in https://bugs.webkit.org/show_bug.cgi?id=181623 to Page.cpp appear to fail when ENABLE(VIDEO) is off.
With ENABLE(VIDEO), HTMLMediaElement.h will #include "ApplicationStateChangeListener.h", but without it, Page.cpp appears to only get the forward declaration from Document.h.
Comment 1 Stephan Szabo 2018-01-16 18:03:30 PST 
Created attachment 331444 [details]
Add #include for ApplicationStateChangeListener
Comment 2 WebKit Commit Bot 2018-01-17 09:36:23 PST 
Comment on attachment 331444 [details]
Add #include for ApplicationStateChangeListener

Clearing flags on attachment: 331444

Committed r227069: <https://trac.webkit.org/changeset/227069>
Comment 3 WebKit Commit Bot 2018-01-17 09:36:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-01-17 09:38:28 PST 
<rdar://problem/36585921>