Bug 181712 - Remove Opensource El Capitan queues from buildbot
Summary: Remove Opensource El Capitan queues from buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ling Ho
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-16 17:55 PST by Ling Ho
Modified: 2018-01-19 09:28 PST (History)
7 users (show)

See Also:

Attachments
Patch (18.88 KB, patch)
2018-01-17 15:29 PST, Ling Ho 		no flags Details | Formatted Diff | Diff
Updated ChangeLog (18.90 KB, patch)
2018-01-17 16:57 PST, Ling Ho 		no flags Details | Formatted Diff | Diff
Patch (18.95 KB, patch)
2018-01-18 10:26 PST, Ling Ho 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ling Ho 2018-01-16 17:55:38 PST 
Remove Opesource El Capitan queues from buildbot
Comment 1 Ling Ho 2018-01-17 15:29:04 PST 
Created attachment 331546 [details]
Patch
Comment 2 Ryan Haddad 2018-01-17 16:47:24 PST 
Comment on attachment 331546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331546&action=review

Aside from the changelog, this looks good.

> Tools/ChangeLog:7
> +

As discussed in person, you can use the prepare-ChangeLog script to generate this entry for you. It will also add the changed files.
Comment 3 Aakash Jain 2018-01-17 16:54:11 PST 
Comment on attachment 331546 [details]
Patch

r+ with ChangeLog fixed.
Comment 4 Ling Ho 2018-01-17 16:57:40 PST 
Created attachment 331563 [details]
Updated ChangeLog
Comment 5 Ryan Haddad 2018-01-18 09:52:48 PST 
Comment on attachment 331563 [details]
Updated ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=331563&action=review

> Tools/ChangeLog:5
> +        Reviewed by Aakash Jain.

There should be an empty line between the bug URL and reviewer.
Comment 6 Ling Ho 2018-01-18 10:26:40 PST 
Created attachment 331637 [details]
Patch
Comment 7 WebKit Commit Bot 2018-01-18 11:01:30 PST 
Comment on attachment 331637 [details]
Patch

Clearing flags on attachment: 331637

Committed r227154: <https://trac.webkit.org/changeset/227154>
Comment 8 WebKit Commit Bot 2018-01-18 11:01:32 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-01-18 11:02:38 PST 
<rdar://problem/36626538>