RESOLVED FIXED 181706
Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't trigger a recording 
https://bugs.webkit.org/show_bug.cgi?id=181706
Summary Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't tri...
Matt Baker
Reported 2018-01-16 14:23:27 PST
Summary: Typing a "space" in the QuickConsole shouldn't trigger a recording. CanvasOverviewContentView should prevent this and allow the default behavior when an editable field has the focus (like TimelineTabContentView). Steps to Reproduce: 1. Goto any page with a canvas 2. Open Canvas tab 3. Focus the QuickConsole prompt, type a space => Canvas recording is triggered
Attachments
Patch (3.16 KB, patch)
2018-01-16 14:28 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-16 14:23:43 PST
<rdar://problem/36558221>
Matt Baker
Comment 2 2018-01-16 14:28:30 PST
Created attachment 331432 [details] Patch
Joseph Pecoraro
Comment 3 2018-01-16 15:02:21 PST
Comment on attachment 331432 [details] Patch Nice! r=me
WebKit Commit Bot
Comment 4 2018-01-16 15:17:40 PST
Comment on attachment 331432 [details] Patch Clearing flags on attachment: 331432 Committed r227008: <https://trac.webkit.org/changeset/227008>
WebKit Commit Bot
Comment 5 2018-01-16 15:17:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.