Bug 181706 - Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't trigger a recording
Summary: Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't tri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasTab
  Show dependency treegraph
 
Reported: 2018-01-16 14:23 PST by Matt Baker
Modified: 2018-01-19 11:49 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.16 KB, patch)
2018-01-16 14:28 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-01-16 14:23:27 PST
Summary:
Typing a "space" in the QuickConsole shouldn't trigger a recording. CanvasOverviewContentView should prevent this and allow the default behavior when an editable field has the focus (like TimelineTabContentView).

Steps to Reproduce:
1. Goto any page with a canvas
2. Open Canvas tab
3. Focus the QuickConsole prompt, type a space
  => Canvas recording is triggered
Comment 1 Radar WebKit Bug Importer 2018-01-16 14:23:43 PST
<rdar://problem/36558221>
Comment 2 Matt Baker 2018-01-16 14:28:30 PST
Created attachment 331432 [details]
Patch
Comment 3 Joseph Pecoraro 2018-01-16 15:02:21 PST
Comment on attachment 331432 [details]
Patch

Nice! r=me
Comment 4 WebKit Commit Bot 2018-01-16 15:17:40 PST
Comment on attachment 331432 [details]
Patch

Clearing flags on attachment: 331432

Committed r227008: <https://trac.webkit.org/changeset/227008>
Comment 5 WebKit Commit Bot 2018-01-16 15:17:42 PST
All reviewed patches have been landed.  Closing bug.