Bug 181694 - Web Inspector: Network Tab - Export HAR Context Menu not working
Summary: Web Inspector: Network Tab - Export HAR Context Menu not working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-16 11:22 PST by Joseph Pecoraro
Modified: 2018-01-22 10:36 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (19.15 KB, patch)
2018-01-16 11:23 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (1.55 KB, patch)
2018-01-16 11:34 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-16 11:22:57 PST
Network Tab - Export HAR Context Menu not working

Steps to Reproduce:
1. Inspect this page
2. Show Network Tab
3. Reload
4. Right Click a Resource > Select "Export HAR"
  => Doesn't do anything

[Error] Uncaught exception in inspector page under contextMenuItemSelected
TypeError: this._HARResources is not a function. (In 'this._HARResources()', 'this._HARResources' is undefined)
    _exportHAR — NetworkTableContentView.js:1386
    _itemSelected — ContextMenu.js:238
    contextMenuItemSelected — ContextMenu.js:175
    contextMenuItemSelected — InspectorFrontendAPI.js:122
Comment 1 Joseph Pecoraro 2018-01-16 11:23:06 PST
<rdar://problem/36479197>
Comment 2 Joseph Pecoraro 2018-01-16 11:23:48 PST
Created attachment 331406 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2018-01-16 11:27:11 PST
Rebasing.
Comment 4 Joseph Pecoraro 2018-01-16 11:34:10 PST
Created attachment 331407 [details]
[PATCH] Proposed Fix
Comment 5 BJ Burg 2018-01-16 11:57:20 PST
Comment on attachment 331407 [details]
[PATCH] Proposed Fix

r=me
Comment 6 WebKit Commit Bot 2018-01-16 12:20:39 PST
Comment on attachment 331407 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 331407

Committed r226992: <https://trac.webkit.org/changeset/226992>
Comment 7 WebKit Commit Bot 2018-01-16 12:20:40 PST
All reviewed patches have been landed.  Closing bug.