WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181692
Move Debug Test262, Release Test262 and Performance queues to Sierra
https://bugs.webkit.org/show_bug.cgi?id=181692
Summary
Move Debug Test262, Release Test262 and Performance queues to Sierra
Ling Ho
Reported
2018-01-16 11:20:12 PST
Buildbot configuration changes required to move Debug Test262, Release Test262 and Performance queues to Sierra. Buildbot dashboard also need to be updated accordingly.
Attachments
Patch
(8.86 KB, patch)
2018-01-16 12:55 PST
,
Ling Ho
ap
: review-
Details
Formatted Diff
Diff
Rename bot433 to bot603, and bot434 to bot632
(8.82 KB, patch)
2018-01-16 19:20 PST
,
Ling Ho
no flags
Details
Formatted Diff
Diff
Problem with previous patch. Uploaded a corrected one.
(9.16 KB, patch)
2018-01-16 19:30 PST
,
Ling Ho
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Ling Ho
Comment 1
2018-01-16 12:55:47 PST
Created
attachment 331417
[details]
Patch
Ling Ho
Comment 2
2018-01-16 13:11:11 PST
Uploaded change to build.webkit-uat.org.
Alexey Proskuryakov
Comment 3
2018-01-16 17:33:21 PST
Comment on
attachment 331417
[details]
Patch Not marking cq+, as I'm not sure if the bots are actually upgraded already.
Ling Ho
Comment 4
2018-01-16 17:53:53 PST
All three bots bot433, bot434 and bot205 have been upgraded to Sierra.
Alexey Proskuryakov
Comment 5
2018-01-16 18:08:30 PST
Comment on
attachment 331417
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=331417&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:52 > + { "name": "bot433", "platform": "mac-sierra" }, > + { "name": "bot434", "platform": "mac-sierra" },
Wait, how is this possible? bot4xx machines are Xserves, and don't support Sierra.
Ling Ho
Comment 6
2018-01-16 19:20:18 PST
Created
attachment 331451
[details]
Rename bot433 to bot603, and bot434 to bot632
Ling Ho
Comment 7
2018-01-16 19:30:56 PST
Created
attachment 331453
[details]
Problem with previous patch. Uploaded a corrected one.
WebKit Commit Bot
Comment 8
2018-01-16 23:04:11 PST
Comment on
attachment 331453
[details]
Problem with previous patch. Uploaded a corrected one. Clearing flags on attachment: 331453 Committed
r227048
: <
https://trac.webkit.org/changeset/227048
>
WebKit Commit Bot
Comment 9
2018-01-16 23:04:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10
2018-01-16 23:05:55 PST
<
rdar://problem/36572976
>
Carlos Alberto Lopez Perez
Comment 11
2018-01-17 06:05:26 PST
(In reply to WebKit Commit Bot from
comment #8
)
> Comment on
attachment 331453
[details]
> Problem with previous patch. Uploaded a corrected one. > > Clearing flags on attachment: 331453 > > Committed
r227048
: <
https://trac.webkit.org/changeset/227048
>
This broke the unit test $ cd Tools/BuildSlaveSupport/build.webkit.org-config/ $ ./steps_unittest.py /home/clopez/webkit/webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/twisted/twisted/spread/jelly.py:102: DeprecationWarning: the sets module is deprecated import sets as _sets /usr/lib/python2.7/dist-packages/cryptography/exceptions.py:7: ImportWarning: Not importing directory '/home/clopez/.local/lib/python2.7/site-packages/enum': missing __init__.py from enum import Enum ..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F....F.F...........................F.................................. ====================================================================== FAIL: test_builder Apple Sierra Debug Test262 (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 495, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple Sierra Debug Test262 (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'test262-test'] ====================================================================== FAIL: test_builder Apple Sierra Release Test262 (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 495, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple Sierra Release Test262 (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'test262-test'] ====================================================================== FAIL: test_builder Apple Sierra Release WK2 (Perf) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 495, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple Sierra Release WK2 (Perf) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'perf-test'] ====================================================================== FAIL: test_unnecessary_expected_results (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 506, in test_unnecessary_expected_results self.assertTrue(builder in builders, "Builder %s doesn't exist, but has unnecessary expected results" % builder) AssertionError: Builder Apple El Capitan Debug Test262 (Tests) doesn't exist, but has unnecessary expected results ---------------------------------------------------------------------- Ran 804 tests in 0.031s FAILED (failures=4)
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug