Buildbot configuration changes required to move Debug Test262, Release Test262 and Performance queues to Sierra. Buildbot dashboard also need to be updated accordingly.
Created attachment 331417 [details] Patch
Uploaded change to build.webkit-uat.org.
Comment on attachment 331417 [details] Patch Not marking cq+, as I'm not sure if the bots are actually upgraded already.
All three bots bot433, bot434 and bot205 have been upgraded to Sierra.
Comment on attachment 331417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331417&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:52 > + { "name": "bot433", "platform": "mac-sierra" }, > + { "name": "bot434", "platform": "mac-sierra" }, Wait, how is this possible? bot4xx machines are Xserves, and don't support Sierra.
Created attachment 331451 [details] Rename bot433 to bot603, and bot434 to bot632
Created attachment 331453 [details] Problem with previous patch. Uploaded a corrected one.
Comment on attachment 331453 [details] Problem with previous patch. Uploaded a corrected one. Clearing flags on attachment: 331453 Committed r227048: <https://trac.webkit.org/changeset/227048>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36572976>
(In reply to WebKit Commit Bot from comment #8) > Comment on attachment 331453 [details] > Problem with previous patch. Uploaded a corrected one. > > Clearing flags on attachment: 331453 > > Committed r227048: <https://trac.webkit.org/changeset/227048> This broke the unit test $ cd Tools/BuildSlaveSupport/build.webkit.org-config/ $ ./steps_unittest.py /home/clopez/webkit/webkit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/twisted/twisted/spread/jelly.py:102: DeprecationWarning: the sets module is deprecated import sets as _sets /usr/lib/python2.7/dist-packages/cryptography/exceptions.py:7: ImportWarning: Not importing directory '/home/clopez/.local/lib/python2.7/site-packages/enum': missing __init__.py from enum import Enum ..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F....F.F...........................F.................................. ====================================================================== FAIL: test_builder Apple Sierra Debug Test262 (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 495, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple Sierra Debug Test262 (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'test262-test'] ====================================================================== FAIL: test_builder Apple Sierra Release Test262 (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 495, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple Sierra Release Test262 (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'test262-test'] ====================================================================== FAIL: test_builder Apple Sierra Release WK2 (Perf) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 495, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: Apple Sierra Release WK2 (Perf) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'perf-test'] ====================================================================== FAIL: test_unnecessary_expected_results (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 506, in test_unnecessary_expected_results self.assertTrue(builder in builders, "Builder %s doesn't exist, but has unnecessary expected results" % builder) AssertionError: Builder Apple El Capitan Debug Test262 (Tests) doesn't exist, but has unnecessary expected results ---------------------------------------------------------------------- Ran 804 tests in 0.031s FAILED (failures=4)