Bug 181689 – Update web platform tests for Visual Viewport API

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ali Juma]

There are two upstream commits to import:

1) The directory for visual viewport WPTs has been renamed from 'viewport' to 'visual-viewport' (https://github.com/w3c/web-platform-tests/commit/f878fee4df619e55c7fbfce1a2ff5e5d4d83a03b).
2) viewport-resize-event-on-load-overflowing-page.html has been updated (https://github.com/w3c/web-platform-tests/commit/03a684d63e62d85cffed38bc942f468692d7d54f).

[Ali Juma]

Created attachment 331401 [details]
Patch

[Ali Juma]

Created attachment 331403 [details]
Patch

[Alex Christensen]

Comment on attachment 331403 [details]
Patch

iOS-sim failure looks related:

Regressions: Unexpected text-only failures (1)
  imported/w3c/web-platform-tests/visual-viewport/viewport-unscaled-size.html [ Failure ]

[EWS Watchlist]

Comment on attachment 331403 [details]
Patch

Attachment 331403 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6095662

New failing tests:
imported/w3c/web-platform-tests/visual-viewport/viewport-unscaled-size.html

[EWS Watchlist]

Created attachment 331411 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Ali Juma]

Created attachment 331413 [details]
Patch

[Ali Juma]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 331403 [details]
> Patch
> 
> iOS-sim failure looks related:
> 
> Regressions: Unexpected text-only failures (1)
>  
> imported/w3c/web-platform-tests/visual-viewport/viewport-unscaled-size.html
> [ Failure ]

This failure is pretty hilarious. WebKitTestRunner and DumpRenderTree hardcode that if a test is in a directory called 'viewport' but not 'visual-viewport', we use a flexible viewport (e.g., see https://trac.webkit.org/browser/webkit/trunk/Tools/WebKitTestRunner/TestOptions.cpp#L42). So renaming the directory from viewport to visual-viewport changed the viewport size. 

The flexible viewport special case is intended for testing viewports in the <meta name="viewport" ...> sense, not visual viewports, so was never supposed to affect these tests to begin with. I've updated the expectation for that test to account for the change in viewport size.

[WebKit Commit Bot]

Comment on attachment 331413 [details]
Patch

Clearing flags on attachment: 331413

Committed r227054: <https://trac.webkit.org/changeset/227054>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36576468>