Bug 181674 - [GTK][WPE] Improve the way glib tests are run
Summary: [GTK][WPE] Improve the way glib tests are run
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-01-16 01:14 PST by Carlos Garcia Campos
Modified: 2018-01-16 02:43 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.80 KB, patch)
2018-01-16 01:22 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-01-16 01:14:33 PST 
Stop using gtester external program and use our own tester from python directly. This way we no longer need to parse the tests output to get the results which is causing problems in WPE bot.
Comment 1 Carlos Garcia Campos 2018-01-16 01:22:08 PST 
Created attachment 331372 [details]
Patch
Comment 2 EWS Watchlist 2018-01-16 01:24:36 PST 
Attachment 331372 [details] did not pass style-queue:


ERROR: Tools/glib/glib_test_runner.py:257:  [GLibTestRunner.run] Instance of 'Popen' has no 'terminate' member  [pylint/E1101] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-01-16 02:42:53 PST 
Comment on attachment 331372 [details]
Patch

Clearing flags on attachment: 331372

Committed r226967: <https://trac.webkit.org/changeset/226967>
Comment 4 WebKit Commit Bot 2018-01-16 02:42:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-16 02:43:22 PST 
<rdar://problem/36539055>