WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181662
[GTK][Win] Two autofill tests are failing
https://bugs.webkit.org/show_bug.cgi?id=181662
Summary
[GTK][Win] Two autofill tests are failing
Michael Catanzaro
Reported
2018-01-15 18:35:20 PST
fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html These tests broke somewhere in the range
r226741
-
r226750
(inclusive). I can't guess which commit is to blame. The text diff is not illuminating; it requires some investigation. Updating expectations accordingly.
Attachments
Image result
(14.04 KB, image/png)
2018-06-03 08:42 PDT
,
Michael Catanzaro
no flags
Details
Image result
(17.40 KB, image/png)
2018-06-03 08:43 PDT
,
Michael Catanzaro
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2018-01-15 18:41:45 PST
I've been over the commit range several times, and I can't guess which commit. It's almost all versioning and branch commits. Maybe
r226745
"Use no-cache fetch mode when loading main documents with location.reload()", but that seems pretty weird. Whatever is to blame, it also fixed fast/forms/input-autofilled.html. Daniel thinks it might have been triggered by a clean build, see
bug #180801
.
Per Arne Vollan
Comment 2
2018-01-18 08:53:19 PST
Updated Windows test expectations in <
https://trac.webkit.org/changeset/227143/webkit
>.
Daniel Bates
Comment 3
2018-06-02 15:44:21 PDT
I do not have a GTK or Windows setup at the moment. Can someone post the the results seen on the GTK and Windows bots for these tests?
Michael Catanzaro
Comment 4
2018-06-02 18:27:58 PDT
Sorry for not posting the diffs when I filed the bug. I usually do that. I don't know any way to get the test results out of the bots without removing the failure expectation, so I just ran the tests locally for GTK. --- /home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/layout-test-results/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt +++ /home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/layout-test-results/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-actual.txt @@ -1,53 +1,102 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x114 - RenderBlock {HTML} at (0,0) size 800x114 - RenderBody {BODY} at (8,16) size 784x90 +layer at (0,0) size 800x228 + RenderBlock {HTML} at (0,0) size 800x228 + RenderBody {BODY} at (8,16) size 784x204 RenderBlock {P} at (0,0) size 784x18 RenderText {#text} at (0,0) size 740x17 text run at (0,0) width 740: "This tests that the Strong Password AutoFill button renders in an auto-filled input. It can only be tested in the test tool." - RenderBlock {DIV} at (0,34) size 784x56 - RenderTextControl {INPUT} at (2,2) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 185x18 - RenderBlock {DIV} at (0,0) size 76x18 - RenderBlock {DIV} at (76,0) size 109x18 - RenderText {#text} at (6,0) size 103x17 - text run at (6,0) width 103: "strong password" - RenderText {#text} at (195,5) size 4x17 - text run at (195,5) width 4: " " - RenderTextControl {INPUT} at (201,2) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 185x18 - RenderBlock {DIV} at (0,0) size 76x18 - RenderBlock {DIV} at (76,0) size 109x18 - RenderText {#text} at (6,0) size 103x17 - text run at (6,0) width 103: "strong password" - RenderText {#text} at (394,5) size 4x17 - text run at (394,5) width 4: " " - RenderTextControl {INPUT} at (398,2) size 306x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 300x18 - RenderBlock {DIV} at (0,0) size 191x18 - RenderBlock {DIV} at (191,0) size 109x18 - RenderText {#text} at (6,0) size 103x17 - text run at (6,0) width 103: "strong password" - RenderText {#text} at (704,5) size 4x17 - text run at (704,5) width 4: " " - RenderTextControl {INPUT} at (2,30) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 185x18 - RenderBlock {DIV} at (0,0) size 76x18 - RenderBlock {DIV} at (76,0) size 109x18 - RenderText {#text} at (6,0) size 103x17 - text run at (6,0) width 103: "strong password" -layer at (13,55) size 76x18 scrollWidth 312 - RenderBlock {DIV} at (0,0) size 76x18 [color=#00000099] - RenderText {#text} at (0,0) size 312x17 - text run at (0,0) width 312: "A quick brown fox jumped over the lazy dog." -layer at (212,55) size 76x18 scrollWidth 258 - RenderBlock {DIV} at (0,0) size 76x18 [color=#00000099] - RenderText {#text} at (0,0) size 258x17 - text run at (0,0) width 258: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}" -layer at (409,55) size 191x18 scrollWidth 258 - RenderBlock {DIV} at (0,0) size 191x18 [color=#00000099] - RenderText {#text} at (0,0) size 258x17 - text run at (0,0) width 258: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}" -layer at (13,83) size 76x18 - RenderBlock {DIV} at (0,0) size 76x18 [color=#00000099] + RenderBlock {DIV} at (0,34) size 784x170 + RenderTextControl {INPUT} at (2,20) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (213,23) size 4x17 + text run at (213,23) width 4: " " + RenderTextControl {INPUT} at (219,20) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (430,23) size 4x17 + text run at (430,23) width 4: " " + RenderTextControl {INPUT} at (434,20) size 306x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (740,23) size 4x17 + text run at (740,23) width 4: " " + RenderTextControl {INPUT} at (744,2) size 26x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (0,0) size 0x0 + RenderTextControl {INPUT} at (2,64) size 209x106 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (213,108) size 4x17 + text run at (213,108) width 4: " " + RenderTextControl {INPUT} at (217,46) size 26x106 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (243,108) size 4x17 + text run at (243,108) width 4: " " + RenderTextControl {INPUT} at (249,105) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] +layer at (13,73) size 203x18 + RenderFlexibleBox {DIV} at (3,3) size 203x18 + RenderBlock {DIV} at (90,0) size 113x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (13,73) size 90x18 + RenderBlock {DIV} at (0,0) size 90x18 +layer at (230,73) size 203x18 + RenderFlexibleBox {DIV} at (3,3) size 203x18 + RenderBlock {DIV} at (90,0) size 113x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (230,73) size 90x18 + RenderBlock {DIV} at (0,0) size 90x18 +layer at (445,73) size 300x18 + RenderFlexibleBox {DIV} at (3,3) size 300x18 + RenderBlock {DIV} at (187,0) size 113x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (445,73) size 187x18 + RenderBlock {DIV} at (0,0) size 187x18 +layer at (755,55) size 20x18 scrollWidth 113 scrollHeight 36 + RenderFlexibleBox {DIV} at (3,3) size 20x18 + RenderBlock {DIV} at (0,18) size 20x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (755,55) size 20x18 + RenderBlock {DIV} at (0,0) size 20x18 +layer at (13,117) size 203x100 + RenderFlexibleBox {DIV} at (3,3) size 203x100 + RenderBlock {DIV} at (90,41) size 113x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (13,158) size 90x18 + RenderBlock {DIV} at (0,41) size 90x18 +layer at (228,140) size 20x18 scrollWidth 113 scrollHeight 36 + RenderFlexibleBox {DIV} at (3,44) size 20x18 + RenderBlock {DIV} at (0,18) size 20x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (228,140) size 20x18 + RenderBlock {DIV} at (0,0) size 20x18 +layer at (260,158) size 203x18 + RenderFlexibleBox {DIV} at (3,3) size 203x18 + RenderBlock {DIV} at (90,0) size 113x18 + RenderText {#text} at (6,0) size 107x17 + text run at (6,0) width 107: "Strong Password" +layer at (260,158) size 90x18 + RenderBlock {DIV} at (0,0) size 90x18 +layer at (13,73) size 90x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 90x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (230,73) size 90x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 90x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (445,73) size 187x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 187x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (755,55) size 20x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 20x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (13,158) size 90x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 90x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (228,140) size 20x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 20x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (260,158) size 90x18 + RenderBlock {DIV} at (0,0) size 90x18 [color=#00000099] --- /home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/layout-test-results/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt +++ /home/mcatanzaro/Projects/WebKit/WebKitBuild/Debug/layout-test-results/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-actual.txt @@ -1,46 +1,89 @@ layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 -layer at (0,0) size 800x132 - RenderBlock {HTML} at (0,0) size 800x132 - RenderBody {BODY} at (8,16) size 784x108 +layer at (0,0) size 800x210 + RenderBlock {HTML} at (0,0) size 800x210 + RenderBody {BODY} at (8,16) size 784x186 RenderBlock {P} at (0,0) size 784x36 RenderText {#text} at (0,0) size 771x35 text run at (0,0) width 771: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the" text run at (0,18) width 53: "test tool." - RenderBlock {DIV} at (0,52) size 784x56 - RenderTextControl {INPUT} at (2,2) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 185x18 - RenderBlock {DIV} at (0,0) size 185x18 - RenderBlock {DIV} at (185,9) size 0x0 - RenderText {#text} at (195,5) size 4x17 - text run at (195,5) width 4: " " - RenderTextControl {INPUT} at (201,2) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 185x18 - RenderBlock {DIV} at (0,0) size 185x18 - RenderBlock {DIV} at (185,9) size 0x0 - RenderText {#text} at (394,5) size 4x17 - text run at (394,5) width 4: " " - RenderTextControl {INPUT} at (398,2) size 306x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 300x18 - RenderBlock {DIV} at (0,0) size 300x18 - RenderBlock {DIV} at (300,9) size 0x0 - RenderText {#text} at (704,5) size 4x17 - text run at (704,5) width 4: " " - RenderTextControl {INPUT} at (2,30) size 191x24 [bgcolor=#FFFFFF] [border: (2px inset #000000)] - RenderFlexibleBox {DIV} at (3,3) size 185x18 - RenderBlock {DIV} at (0,0) size 185x18 - RenderBlock {DIV} at (185,9) size 0x0 -layer at (13,73) size 185x18 scrollWidth 312 - RenderBlock {DIV} at (0,0) size 185x18 [color=#00000099] - RenderText {#text} at (0,0) size 312x17 - text run at (0,0) width 312: "A quick brown fox jumped over the lazy dog." -layer at (212,73) size 185x18 scrollWidth 258 - RenderBlock {DIV} at (0,0) size 185x18 [color=#00000099] - RenderText {#text} at (0,0) size 258x17 - text run at (0,0) width 258: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}" -layer at (409,73) size 300x18 + RenderBlock {DIV} at (0,52) size 784x134 + RenderTextControl {INPUT} at (2,2) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (213,4) size 4x17 + text run at (213,4) width 4: " " + RenderTextControl {INPUT} at (219,2) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (430,4) size 4x17 + text run at (430,4) width 4: " " + RenderTextControl {INPUT} at (434,2) size 306x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (740,4) size 4x17 + text run at (740,4) width 4: " " + RenderTextControl {INPUT} at (744,2) size 26x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (0,0) size 0x0 + RenderTextControl {INPUT} at (2,28) size 209x106 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (213,71) size 4x17 + text run at (213,71) width 4: " " + RenderTextControl {INPUT} at (217,28) size 26x106 [bgcolor=#FAFFBD] [border: (2px inset #000000)] + RenderText {#text} at (243,71) size 4x17 + text run at (243,71) width 4: " " + RenderTextControl {INPUT} at (249,69) size 209x24 [bgcolor=#FAFFBD] [border: (2px inset #000000)] +layer at (13,73) size 203x18 + RenderFlexibleBox {DIV} at (3,3) size 203x18 + RenderBlock {DIV} at (203,9) size 0x0 +layer at (13,73) size 203x18 + RenderBlock {DIV} at (0,0) size 203x18 +layer at (230,73) size 203x18 + RenderFlexibleBox {DIV} at (3,3) size 203x18 + RenderBlock {DIV} at (203,9) size 0x0 +layer at (230,73) size 203x18 + RenderBlock {DIV} at (0,0) size 203x18 +layer at (445,73) size 300x18 + RenderFlexibleBox {DIV} at (3,3) size 300x18 + RenderBlock {DIV} at (300,9) size 0x0 +layer at (445,73) size 300x18 + RenderBlock {DIV} at (0,0) size 300x18 +layer at (755,73) size 20x18 + RenderFlexibleBox {DIV} at (3,3) size 20x18 + RenderBlock {DIV} at (20,9) size 0x0 +layer at (755,73) size 20x18 + RenderBlock {DIV} at (0,0) size 20x18 +layer at (13,99) size 203x100 + RenderFlexibleBox {DIV} at (3,3) size 203x100 + RenderBlock {DIV} at (203,50) size 0x0 +layer at (13,140) size 203x18 + RenderBlock {DIV} at (0,41) size 203x18 +layer at (228,99) size 20x100 + RenderFlexibleBox {DIV} at (3,3) size 20x100 + RenderBlock {DIV} at (20,50) size 0x0 +layer at (228,140) size 20x18 + RenderBlock {DIV} at (0,41) size 20x18 +layer at (260,140) size 203x18 + RenderFlexibleBox {DIV} at (3,3) size 203x18 + RenderBlock {DIV} at (203,9) size 0x0 +layer at (260,140) size 203x18 + RenderBlock {DIV} at (0,0) size 203x18 +layer at (13,73) size 203x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 203x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (230,73) size 203x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 203x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (445,73) size 300x18 scrollWidth 430 RenderBlock {DIV} at (0,0) size 300x18 [color=#00000099] - RenderText {#text} at (0,0) size 258x17 - text run at (0,0) width 258: "\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}\x{2022}" -layer at (13,101) size 185x18 - RenderBlock {DIV} at (0,0) size 185x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (755,73) size 20x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 20x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (13,140) size 203x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 203x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (228,140) size 20x18 scrollWidth 430 + RenderBlock {DIV} at (0,0) size 20x18 [color=#00000099] + RenderText {#text} at (0,0) size 430x18 + text run at (0,0) width 430: "A quick brown fox jumped over the lazy dog." +layer at (260,140) size 203x18 + RenderBlock {DIV} at (0,0) size 203x18 [color=#00000099]
Michael Catanzaro
Comment 5
2018-06-03 08:42:57 PDT
Created
attachment 341865
[details]
Image result Oh, there are image results too. The test runner created -expected.png files, so these are actually the actual results waiting to be committed as new expected results (there are currently no expected image results).
Michael Catanzaro
Comment 6
2018-06-03 08:43:34 PDT
Created
attachment 341866
[details]
Image result
Diego Pino
Comment 7
2024-05-29 03:09:54 PDT
This test is passing after updating baselines in
275882@main
.
https://results.webkit.org/?platform=GTK&suite=layout-tests&test=fast%2Fforms%2Fauto-fill-button%2Finput-strong-password-auto-fill-button.html
After updating test expectations in
279290@main
, there are no more tests referring to this bug. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug