Bug 181653 - Test programs should only be built in developer mode
Summary: Test programs should only be built in developer mode
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Keywords: InRadar
Depends on:
Reported: 2018-01-15 11:59 PST by Michael Catanzaro
Modified: 2018-01-16 07:34 PST (History)
7 users (show)

See Also:

Patch (1.65 KB, patch)
2018-01-15 12:00 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-01-15 11:59:44 PST
JSC builds these test programs unconditionally:


But they're not exposed or installed in release mode. Our other tests all depend on developer mode, so let's be consistent.

I noticed these recently because having installed binaries that depend on internal symbols of JSC makes it harder to change how we link JSC, though hopefully we'll never have to bother with that again anytime soon....
Comment 1 Michael Catanzaro 2018-01-15 12:00:51 PST
Created attachment 331350 [details]
Comment 2 Konstantin Tokarev 2018-01-15 14:37:32 PST
These are unit tests, and it might make sense to build unit tests in non-developer builds, e.g. packagers could use them for smoke checking...
Comment 3 Michael Catanzaro 2018-01-15 15:21:46 PST
You'd think, but our test scripts simply don't support running from tarball builds, and there's not much point in having a bunch of standalone test binaries in the builddir.

That might be worth changing, of course.
Comment 4 WebKit Commit Bot 2018-01-16 07:33:26 PST
Comment on attachment 331350 [details]

Clearing flags on attachment: 331350

Committed r226971: <https://trac.webkit.org/changeset/226971>
Comment 5 WebKit Commit Bot 2018-01-16 07:33:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-16 07:34:18 PST