Bug 181647 – [GStreamer] misc fixes and cleanups

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

.

[Philippe Normand]

Created attachment 331336 [details]
Patch

[Michael Catanzaro]

Comment on attachment 331336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331336&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Switch to
> +        streaming code path when no content-length was reported by the
> +        http source element.

Maybe this one is worth splitting into a separate patch?

> Source/WebCore/ChangeLog:31
> +        (webkit_web_src_init): Enable keepAlive by default like in souphttpsrc.

Ditto?

> Source/WebCore/ChangeLog:37
> +        (CachedResourceStreamingClient::responseReceived): Change appsrc
> +        stream-type when we wan't seek. Also update caps like souphttpsrc
> +        does and emit headers as an element message, like souphttpsrc.

Ditto?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:482
> +    GST_DEBUG_OBJECT(src, "Persistent connection support %s", priv->keepAlive ? "enabled":"disabled");

Leave spaces around the :

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:799
> +    GST_DEBUG_OBJECT(src, "Size: %" G_GINT64_FORMAT ", seekable: %s", priv->size, priv->seekable ? "yes":"no");

Ditto

[Philippe Normand]

Created attachment 331374 [details]
Patch

[Philippe Normand]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 331336 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331336&action=review
> 
> > Source/WebCore/ChangeLog:18
> > +        (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Switch to
> > +        streaming code path when no content-length was reported by the
> > +        http source element.
> 
> Maybe this one is worth splitting into a separate patch?
> 

Ok

> > Source/WebCore/ChangeLog:31
> > +        (webkit_web_src_init): Enable keepAlive by default like in souphttpsrc.
> 
> Ditto?
> 

Humpf. I don't think so.

> > Source/WebCore/ChangeLog:37
> > +        (CachedResourceStreamingClient::responseReceived): Change appsrc
> > +        stream-type when we wan't seek. Also update caps like souphttpsrc
> > +        does and emit headers as an element message, like souphttpsrc.
> 
> Ditto?
> 

Yes

> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:482
> > +    GST_DEBUG_OBJECT(src, "Persistent connection support %s", priv->keepAlive ? "enabled":"disabled");
> 
> Leave spaces around the :
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:799
> > +    GST_DEBUG_OBJECT(src, "Size: %" G_GINT64_FORMAT ", seekable: %s", priv->size, priv->seekable ? "yes":"no");
> 
> Ditto

[Philippe Normand]

Committed r226973: <https://trac.webkit.org/changeset/226973>

[Radar WebKit Bug Importer]

<rdar://problem/36543956>