Bug 181644 – WebDriver: several element_send_keys tests are failing since added

• Status: RESOLVED
• Resolution: FIXED
• Component: WebDriver

[Carlos Garcia Campos]

______________________________________________________________________ test_element_outside_of_not_scrollable_viewport _______________________________________________________________________

session = <webdriver.client.Session object at 0x7f3600204b50>

    def test_element_outside_of_not_scrollable_viewport(session):
        session.url = inline("<input style=\"position: relative; left: -9999px;\">")
        element = session.find.css("input", all=False)
    
        response = send_keys_to_element(session, element, "foo")
>       assert_success(response)

element    = <webdriver.client.Element object at 0x7f360003ef90>
response   = <Response status=400 error=<InvalidArgumentException http_status=400>>
session    = <webdriver.client.Session object at 0x7f3600204b50>

WebDriverTests/imported/w3c/webdriver/tests/element_send_keys/scroll_into_view.py:20: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

response = <Response status=400 error=<InvalidArgumentException http_status=400>>, value = None

    def assert_success(response, value=None):
        """
        Verify that the provided webdriver.Response instance described
        a valid error response as defined by `dfn-send-an-error` and
        the provided error code.
    
        :param response: ``webdriver.Response`` instance.
        :param value: Expected value of the response body, if any.
        """
>       assert response.status == 200, str(response.error)
E       AssertionError: invalid argument (400):

response   = <Response status=400 error=<InvalidArgumentException http_status=400>>
value      = None

WebDriverTests/imported/w3c/webdriver/tests/support/asserts.py:83: AssertionError

[Carlos Garcia Campos]

Tests in imported/w3c/webdriver/tests/element_send_keys/interactability.py are failing with similar bt.

[Carlos Garcia Campos]

This is because we are implementing an old version of the spec that received a "value" parameter to send keys command, instead of the "text" one.

[Carlos Garcia Campos]

Created attachment 347010 [details]
Patch

[EWS Watchlist]

Attachment 347010 [details] did not pass style-queue:


ERROR: Source/WebDriver/Session.h:109:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/Session.cpp:1720:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Committed r234836: <https://trac.webkit.org/changeset/234836>

[Radar WebKit Bug Importer]

<rdar://problem/43272647>