Bug 181643 - Clear Caches volatile storage as a memory optimization.
Summary: Clear Caches volatile storage as a memory optimization.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-15 00:49 PST by youenn fablet
Modified: 2018-01-17 01:23 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2018-01-15 00:52 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-01-15 00:49:31 PST 
Caches::m_volatileStorage is not cleared when clearing the memory representation.
It should be done to release some memory.
Comment 1 youenn fablet 2018-01-15 00:52:08 PST 
Created attachment 331324 [details]
Patch
Comment 2 Chris Dumez 2018-01-16 08:57:20 PST 
Comment on attachment 331324 [details]
Patch

Is this really just a optimization? If the user asks to clear all data, then we try to read and return data from m_volatileStorage, wouldn't it be a bug?
Comment 3 WebKit Commit Bot 2018-01-17 01:22:40 PST 
Comment on attachment 331324 [details]
Patch

Clearing flags on attachment: 331324

Committed r227052: <https://trac.webkit.org/changeset/227052>
Comment 4 WebKit Commit Bot 2018-01-17 01:22:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-17 01:23:55 PST 
<rdar://problem/36576295>