Bug 181637 – Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

<rdar://problem/36508471>

[Wenson Hsieh]

Created attachment 331309 [details]
First pass

[Wenson Hsieh]

Created attachment 331312 [details]
Try to fix Windows builds

[Tim Horton]

Comment on attachment 331312 [details]
Try to fix Windows builds

View in context: https://bugs.webkit.org/attachment.cgi?id=331312&action=review

> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:293
> +    HashMap<AtomicString, AtomicString> subresourceURLToClientURLMap;

Don’t see the need for AtomicString?

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:110
> +    WKBundlePageReplacementURLForResource                               replacementURLForResource;

This is a big no-no. You need to make a new version and append this to the bottom.

[Wenson Hsieh]

Comment on attachment 331312 [details]
Try to fix Windows builds

View in context: https://bugs.webkit.org/attachment.cgi?id=331312&action=review

>> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:293
>> +    HashMap<AtomicString, AtomicString> subresourceURLToClientURLMap;
> 
> Don’t see the need for AtomicString?

Just spoke with Ryosuke about this — since the keys and values of this dictionary are either element attribute values or going to become attribute values after replacement, we'll end up making AtomicStrings for these anyways. For this reason, the existing blobURLMaps also in this file are HashMap<AtomicString, AtomicString>, so it seems like this should also be a HashMap<AtomicString, AtomicString>.

>> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:110
>> +    WKBundlePageReplacementURLForResource                               replacementURLForResource;
> 
> This is a big no-no. You need to make a new version and append this to the bottom.

Got it — fixed!

[Wenson Hsieh]

Created attachment 331450 [details]
Bump WKBundlePageEditorClient version

[Wenson Hsieh]

Created attachment 331452 [details]
Bump WKBundlePageEditorClient version

[WebKit Commit Bot]

Comment on attachment 331452 [details]
Bump WKBundlePageEditorClient version

Clearing flags on attachment: 331452

Committed r227068: <https://trac.webkit.org/changeset/227068>