Bug 181630 – Remove makePoisonedUnique

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[JF Bastien]

I added a conversion from std::unique_ptr, so we can just use std::make_unique and it'll auto-poison when converted.

[Radar WebKit Bug Importer]

<rdar://problem/36498623>

[JF Bastien]

Created attachment 331284 [details]
patch

[Mark Lam]

Comment on attachment 331284 [details]
patch

r=me if you also fix the API tests and the EWS bots is green after that.

[JF Bastien]

Created attachment 331307 [details]
patch

Don't just build JSC!

[WebKit Commit Bot]

Comment on attachment 331307 [details]
patch

Rejecting attachment 331307 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 331307, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
s FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp.rej
patching file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp
Hunk #2 FAILED at 121.
Hunk #3 FAILED at 134.
2 out of 3 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6070144

[JF Bastien]

Created attachment 331353 [details]
patch

Update to rebase on Mark's patch. The array version diverged a bunch from make_unique's version, so I removed it as well.

[WebKit Commit Bot]

Comment on attachment 331353 [details]
patch

Clearing flags on attachment: 331353

Committed r226956: <https://trac.webkit.org/changeset/226956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.