Bug 181630 - Remove makePoisonedUnique
Summary: Remove makePoisonedUnique
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-13 12:12 PST by JF Bastien
Modified: 2018-01-15 14:02 PST (History)
14 users (show)

See Also:


Attachments
patch (12.03 KB, patch)
2018-01-13 12:15 PST, JF Bastien
mark.lam: review+
Details | Formatted Diff | Diff
patch (16.00 KB, patch)
2018-01-14 09:03 PST, JF Bastien
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (16.19 KB, patch)
2018-01-15 12:57 PST, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2018-01-13 12:12:09 PST
I added a conversion from std::unique_ptr, so we can just use std::make_unique and it'll auto-poison when converted.
Comment 1 Radar WebKit Bug Importer 2018-01-13 12:12:32 PST
<rdar://problem/36498623>
Comment 2 JF Bastien 2018-01-13 12:15:01 PST
Created attachment 331284 [details]
patch
Comment 3 Mark Lam 2018-01-13 21:54:40 PST
Comment on attachment 331284 [details]
patch

r=me if you also fix the API tests and the EWS bots is green after that.
Comment 4 JF Bastien 2018-01-14 09:03:37 PST
Created attachment 331307 [details]
patch

Don't just build JSC!
Comment 5 WebKit Commit Bot 2018-01-14 09:04:48 PST
Comment on attachment 331307 [details]
patch

Rejecting attachment 331307 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 331307, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
s FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp.rej
patching file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp
Hunk #2 FAILED at 121.
Hunk #3 FAILED at 134.
2 out of 3 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/6070144
Comment 6 JF Bastien 2018-01-15 12:57:59 PST
Created attachment 331353 [details]
patch

Update to rebase on Mark's patch. The array version diverged a bunch from make_unique's version, so I removed it as well.
Comment 7 WebKit Commit Bot 2018-01-15 14:02:49 PST
Comment on attachment 331353 [details]
patch

Clearing flags on attachment: 331353

Committed r226956: <https://trac.webkit.org/changeset/226956>
Comment 8 WebKit Commit Bot 2018-01-15 14:02:51 PST
All reviewed patches have been landed.  Closing bug.