Bug 181628 - Web Inspector: Make Console's Execution Context picker stand out when it is non-default
Summary: Web Inspector: Make Console's Execution Context picker stand out when it is n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-12 21:35 PST by Joseph Pecoraro
Modified: 2018-01-16 14:26 PST (History)
6 users (show)

See Also:

Attachments
[IMAGE] Page Execution Context Unchanged (50.69 KB, image/png)
2018-01-12 21:41 PST, Joseph Pecoraro 		no flags Details
[IMAGE] Non-Default Execution Context Highlight (51.39 KB, image/png)
2018-01-12 21:41 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (5.08 KB, patch)
2018-01-12 21:42 PST, Joseph Pecoraro 		mattbaker: review+
mattbaker: commit-queue+
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (5.05 KB, patch)
2018-01-16 11:18 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-12 21:35:49 PST 
Make Console's Execution Context picker stand out when it is non-default

Steps to reproduce:
1. Inspect <http://mdn.github.io/simple-web-worker/>
2. Toggle between "Page" and "Worker" in quick console
  => Easy to not realize you are in a Worker context.
Comment 1 Radar WebKit Bug Importer 2018-01-12 21:36:06 PST 
<rdar://problem/36492044>
Comment 2 Joseph Pecoraro 2018-01-12 21:41:36 PST 
Created attachment 331273 [details]
[IMAGE] Page Execution Context Unchanged
Comment 3 Joseph Pecoraro 2018-01-12 21:41:55 PST 
Created attachment 331274 [details]
[IMAGE] Non-Default Execution Context Highlight
Comment 4 Joseph Pecoraro 2018-01-12 21:42:06 PST 
Created attachment 331275 [details]
[PATCH] Proposed Fix
Comment 5 Nikita Vasilyev 2018-01-15 16:54:59 PST 
Comment on attachment 331275 [details]
[PATCH] Proposed Fix

Looks good, I like this!

View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review

> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
> +.quick-console > .navigation-bar > .hierarchical-path.non-default-execution-context .execution-context {
> +    background: var(--selected-background-color);
> +    border-radius: 3px;
> +    color: white;

Should we use `color: var(--selected-foreground-color);` since it's used for the arrows?
Comment 6 Joseph Pecoraro 2018-01-16 10:52:53 PST 
Comment on attachment 331275 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review

>> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
>> +    color: white;
> 
> Should we use `color: var(--selected-foreground-color);` since it's used for the arrows?

Err, you're correct. And I do that down below. I think this line can be removed.
Comment 7 Joseph Pecoraro 2018-01-16 11:18:41 PST 
Created attachment 331405 [details]
[PATCH] Proposed Fix

It was needed for the text portion of the picker (non-arrows). Updated to use the variable.
Comment 8 Matt Baker 2018-01-16 12:36:58 PST 
Comment on attachment 331275 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=331275&action=review

r=me

>>> Source/WebInspectorUI/UserInterface/Views/QuickConsole.css:102
>>> +    color: white;
>> 
>> Should we use `color: var(--selected-foreground-color);` since it's used for the arrows?
> 
> Err, you're correct. And I do that down below. I think this line can be removed.

Good catch!
Comment 9 WebKit Commit Bot 2018-01-16 14:26:31 PST 
Comment on attachment 331405 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 331405

Committed r227003: <https://trac.webkit.org/changeset/227003>
Comment 10 WebKit Commit Bot 2018-01-16 14:26:32 PST 
All reviewed patches have been landed.  Closing bug.