Bug 181627 – [WebAuthN] Implement dummy WebAuthN IDLs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

Implement dummy WebAuthN IDLs.

[Jiewen Tan]

<rdar://problem/36459864>

[Jiewen Tan]

Created attachment 331271 [details]
Patch

[Jiewen Tan]

Created attachment 331277 [details]
Patch

[Alex Christensen]

Comment on attachment 331277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331277&action=review

> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:37
> +    RefPtr<ArrayBuffer> authenticatorData();

I think these should just return a pointer.

> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:42
> +    RefPtr<ArrayBuffer> m_authenticatorData;

Can we not make any of these Ref's?

> Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:28
> +// enum UserVerificationRequirement {

Can we add this later, rather than adding commented things?

> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:61
> +    unsigned long timeout;

Could we give these initializer lists to avoid uninitialized members?

> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.idl:31
> +// enum AttestationConveyancePreference {

ditto

[Jiewen Tan]

Comment on attachment 331277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331277&action=review

Thanks Alex for r+ this patch.

>> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:37
>> +    RefPtr<ArrayBuffer> authenticatorData();
> 
> I think these should just return a pointer.

May I ask why a pointer is better than RefPtr?

>> Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.h:42
>> +    RefPtr<ArrayBuffer> m_authenticatorData;
> 
> Can we not make any of these Ref's?

If not Ref's, what data type should be there?

>> Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:28
>> +// enum UserVerificationRequirement {
> 
> Can we add this later, rather than adding commented things?

Certainly.

>> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:61
>> +    unsigned long timeout;
> 
> Could we give these initializer lists to avoid uninitialized members?

Certainly.

>> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.idl:31
>> +// enum AttestationConveyancePreference {
> 
> ditto

Fixed.

[Jiewen Tan]

Created attachment 331409 [details]
Patch for landing

[Jiewen Tan]

Comment on attachment 331409 [details]
Patch for landing

The Win EWS bot seems to have some issues. cq+ regardless of it.

[WebKit Commit Bot]

Comment on attachment 331409 [details]
Patch for landing

Rejecting attachment 331409 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 331409, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
org/git/WebKit
   4b0009cc0a2..958c295cde9  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 227003 = 4b0009cc0a2bd83b4e417c6c836c36dba18b913d
r227004 = 958c295cde97fe554d73518321cc39caeb20eb22
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/6098675

[Jiewen Tan]

Committed r227007: <https://trac.webkit.org/changeset/227007>