Bug 181607 - Web Inspector: Support JSX (React) syntax highlighting
Summary: Web Inspector: Support JSX (React) syntax highlighting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-12 12:06 PST by Joseph Pecoraro
Modified: 2018-01-12 13:03 PST (History)
5 users (show)

See Also:

Attachments
[IMAGE] JSX Before (388.04 KB, image/png)
2018-01-12 12:09 PST, Joseph Pecoraro 		no flags Details
[IMAGE] JSX After (406.48 KB, image/png)
2018-01-12 12:09 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (9.26 KB, patch)
2018-01-12 12:09 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-12 12:06:44 PST 
Support JSX (React) syntax highlighting

Common file extension: .jsx
Common mime type: text/jsx

CodeMirror has a mode for this that we can include.
Comment 1 Joseph Pecoraro 2018-01-12 12:07:17 PST 
<rdar://problem/36442564>
Comment 2 Joseph Pecoraro 2018-01-12 12:09:04 PST 
Created attachment 331221 [details]
[IMAGE] JSX Before
Comment 3 Joseph Pecoraro 2018-01-12 12:09:14 PST 
Created attachment 331222 [details]
[IMAGE] JSX After
Comment 4 Joseph Pecoraro 2018-01-12 12:09:35 PST 
Created attachment 331223 [details]
[PATCH] Proposed Fix
Comment 5 Joseph Pecoraro 2018-01-12 12:12:27 PST 
Comment on attachment 331223 [details]
[PATCH] Proposed Fix

Hmm, the XHR fetched .jsx text/jsx files don't look syntax highlighted. Let me check on that.
Comment 6 Joseph Pecoraro 2018-01-12 12:15:01 PST 
Comment on attachment 331223 [details]
[PATCH] Proposed Fix

Oh it does, I was just using the wrong browser window.
Comment 7 BJ Burg 2018-01-12 12:19:51 PST 
Comment on attachment 331223 [details]
[PATCH] Proposed Fix

r=me
Comment 8 WebKit Commit Bot 2018-01-12 13:03:27 PST 
Comment on attachment 331223 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 331223

Committed r226909: <https://trac.webkit.org/changeset/226909>
Comment 9 WebKit Commit Bot 2018-01-12 13:03:28 PST 
All reviewed patches have been landed.  Closing bug.