Bug 181594 – [EME] Add layout test for the MSE playback of ClearKey encrypted audio and video

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Yacine Bandou]

Add new layout tests in order to test the playback of ClearKey encrypted content:

- clearKey-cenc-audio-playback-mse : test the MSE playback of ClearKey encrypted audio track wich use the full-sample encryption.

- clearKey-cenc-video-playback-mse : test the MSE playback of ClearKey encrypted video track wich use the sub-sample encryption scheme.

[Yacine Bandou]

Created attachment 331208 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 331208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331208&action=review

> LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html:33
> +        let ms = new MediaSourceLoaderSimple(video);

You can probably use const here.

> LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:17
> +        let emeHandler = new EncryptedMediaHandler(video, videoConf);

You can probably use const here.

> LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:33
> +        let ms = new MediaSourceLoaderSimple(video);

Ditto.

> LayoutTests/platform/wpe/TestExpectations:1132
> +webkit.org/b/180080 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Crash ]

?

[Yacine Bandou]

(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 331208 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331208&action=review
> 
> > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html:33
> > +        let ms = new MediaSourceLoaderSimple(video);
> 
> You can probably use const here.

Yes

> 
> > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:17
> > +        let emeHandler = new EncryptedMediaHandler(video, videoConf);
> 
> You can probably use const here.

Yes

> 
> > LayoutTests/media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html:33
> > +        let ms = new MediaSourceLoaderSimple(video);
> 
> Ditto.

Yes

> 
> > LayoutTests/platform/wpe/TestExpectations:1132
> > +webkit.org/b/180080 media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html [ Crash ]
> 
> ?

Crash because the content follow the full-sample encryption, thus the subSamplesBuffer is nul

So we crash in this line:

>Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:240
GstMapInfo subSamplesMap;
gboolean subsamplesBufferMapped = gst_buffer_map(subSamplesBuffer, &subSamplesMap, GST_MAP_READ);

[Yacine Bandou]

Created attachment 331335 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 331335 [details]
Patch

Clearing flags on attachment: 331335

Committed r226966: <https://trac.webkit.org/changeset/226966>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36536151>