Bug 181572 - Disable Atomics when SharedArrayBuffer isn’t enabled
Summary: Disable Atomics when SharedArrayBuffer isn’t enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-11 19:43 PST by Saam Barati
Modified: 2018-01-17 17:58 PST (History)
9 users (show)

See Also:

Attachments
patch (3.85 KB, patch)
2018-01-16 12:09 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.55 KB, patch)
2018-01-16 12:16 PST, Saam Barati 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
patch (5.38 KB, patch)
2018-01-17 16:49 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-01-11 19:43:11 PST 
...
Comment 1 Saam Barati 2018-01-16 12:07:36 PST 
<rdar://problem/36553206>
Comment 2 Saam Barati 2018-01-16 12:09:57 PST 
Created attachment 331410 [details]
patch

This might make some tests fail. I'll let EWS tell me which tests need updating.
Comment 3 Saam Barati 2018-01-16 12:16:52 PST 
Created attachment 331412 [details]
patch
Comment 4 EWS Watchlist 2018-01-16 13:02:21 PST 
Comment on attachment 331412 [details]
patch

Attachment 331412 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/6096429

New failing tests:
stress/isLockFree.js.ftl-eager
stress/isLockFree.js.ftl-eager-no-cjit
stress/isLockFree.js.no-cjit-collect-continuously
stress/isLockFree.js.ftl-eager-no-cjit-b3o1
stress/isLockFree.js.default
stress/isLockFree.js.ftl-no-cjit-validate-sampling-profiler
stress/isLockFree.js.no-cjit-validate-phases
stress/isLockFree.js.ftl-no-cjit-small-pool
stress/isLockFree.js.dfg-eager
stress/isLockFree.js.dfg-eager-no-cjit-validate
stress/isLockFree.js.ftl-no-cjit-b3o1
stress/isLockFree.js.ftl-no-cjit-no-inline-validate
stress/isLockFree.js.dfg-maximal-flush-validate-no-cjit
stress/isLockFree.js.ftl-no-cjit-no-put-stack-validate
stress/isLockFree.js.no-ftl
stress/isLockFree.js.no-llint
Comment 5 Saam Barati 2018-01-17 16:49:01 PST 
Created attachment 331560 [details]
patch
Comment 6 Michael Saboff 2018-01-17 16:50:19 PST 
Comment on attachment 331560 [details]
patch

r=me
Comment 7 WebKit Commit Bot 2018-01-17 17:58:29 PST 
Comment on attachment 331560 [details]
patch

Clearing flags on attachment: 331560

Committed r227104: <https://trac.webkit.org/changeset/227104>
Comment 8 WebKit Commit Bot 2018-01-17 17:58:30 PST 
All reviewed patches have been landed.  Closing bug.