Bug 181563 - We should be able to terminate service workers that are unresponsive
Summary: We should be able to terminate service workers that are unresponsive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-11 16:07 PST by Chris Dumez
Modified: 2019-12-05 10:35 PST (History)
10 users (show)

See Also:

Attachments
WIP Patch (8.49 KB, patch)
2018-01-12 16:50 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (4.26 KB, patch)
2018-01-12 17:04 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.92 KB, patch)
2018-01-17 15:57 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-01-11 16:07:47 PST 
We should be able to terminate service workers that are unresponsive (e.g. in a tight loop).
Comment 1 Chris Dumez 2018-01-11 16:08:02 PST 
<rdar://problem/35280031>
Comment 2 Chris Dumez 2018-01-12 16:50:45 PST 
Created attachment 331255 [details]
WIP Patch
Comment 3 Chris Dumez 2018-01-12 17:04:23 PST 
Created attachment 331257 [details]
WIP Patch
Comment 4 EWS Watchlist 2018-01-12 17:07:14 PST 
Attachment 331257 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/SWContextManager.cpp:29:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2018-01-17 15:57:05 PST 
Created attachment 331551 [details]
Patch
Comment 6 Chris Dumez 2018-01-18 15:55:25 PST 
ping review?
Comment 7 Alex Christensen 2018-01-18 16:33:36 PST 
This has the side effect of terminating all service workers
Comment 8 Chris Dumez 2018-01-18 16:34:32 PST 
(In reply to Alex Christensen from comment #7)
> This has the side effect of terminating all service workers

Yes, there is no other way and this is fine. We already deal properly with the SW process crashing and we restart those service workers as needed.
Comment 9 WebKit Commit Bot 2018-01-18 16:57:46 PST 
Comment on attachment 331551 [details]
Patch

Clearing flags on attachment: 331551

Committed r227174: <https://trac.webkit.org/changeset/227174>
Comment 10 WebKit Commit Bot 2018-01-18 16:57:48 PST 
All reviewed patches have been landed.  Closing bug.