Bug 181561 - Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
Summary: Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 181332 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-01-11 15:37 PST by Alexey Proskuryakov
Modified: 2018-01-11 16:23 PST (History)
7 users (show)

See Also:

Attachments
CQ log (14.56 KB, text/plain)
2018-01-11 15:37 PST, Alexey Proskuryakov 		no flags Details
Patch (1.50 KB, patch)
2018-01-11 15:56 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2018-01-11 16:04 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2018-01-11 16:19 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-01-11 15:37:01 PST 
Created attachment 331127 [details]
CQ log

Commit queue silently stopped working on https://bugs.webkit.org/attachment.cgi?id=330864&action=prettypatch
Comment 1 Alexey Proskuryakov 2018-01-11 15:37:33 PST 
This bot failed in the same way on the next patch, so it's not just a one off.
Comment 2 Alexey Proskuryakov 2018-01-11 15:43:14 PST 
I don't see this error in recent logs on webkit-cq-02 or webkit-cq-03. Only webkit-cq-01 so far.
Comment 3 Jonathan Bedard 2018-01-11 15:51:56 PST 
We have a bunch of flakey layout tests, that's why commit queue is taking so long.
Comment 4 Radar WebKit Bug Importer 2018-01-11 15:53:21 PST 
<rdar://problem/36452652>
Comment 5 Aakash Jain 2018-01-11 15:55:38 PST 
Same as https://bugs.webkit.org/show_bug.cgi?id=181332
Comment 6 Aakash Jain 2018-01-11 15:55:48 PST 
Might be a network issue while fetching the page from bugzilla, or the fetched page from bugzilla might not have the bz_result_count tag and BeautifulSoup fails to parse it properly.
Comment 7 Jonathan Bedard 2018-01-11 15:56:40 PST 
Created attachment 331129 [details]
Patch
Comment 8 Jonathan Bedard 2018-01-11 15:57:33 PST 
(In reply to Jonathan Bedard from comment #7)
> Created attachment 331129 [details]
> Patch

I'm concerned that this doesn't address the root cause, but it shouldn't be harmful.
Comment 9 Aakash Jain 2018-01-11 16:04:25 PST 
Comment on attachment 331129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331129&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:142
> +        if result_count_text is None:

Please add a log statement as well to print results_page and results_url, so that we can debug it next time similar issue happens.
Comment 10 Jonathan Bedard 2018-01-11 16:04:56 PST 
Created attachment 331133 [details]
Patch
Comment 11 Jonathan Bedard 2018-01-11 16:19:43 PST 
Created attachment 331137 [details]
Patch
Comment 12 Jonathan Bedard 2018-01-11 16:20:43 PST 
(In reply to Jonathan Bedard from comment #11)
> Created attachment 331137 [details]
> Patch

Committed in <https://trac.webkit.org/r226819>.
Comment 13 Aakash Jain 2018-01-11 16:22:55 PST 
*** Bug 181332 has been marked as a duplicate of this bug. ***