Our webkitpy unit tests which test the logic behind starting and stopping certain web servers are flakey because they run the actual check to verify if a certain server is running. This is incorrect, we should be mocking out this check.
<rdar://problem/36448273>
Created attachment 331110 [details] Patch
webkitpy tests are failing with the following test failure: webkitpy.layout_tests.controllers.layout_test_runner_unittest.LayoutTestRunnerTests.test_servers_started failed: Traceback (most recent call last): File ".../WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py", line 178, in test_servers_started self.assertEqual(self.http_started, True) AssertionError: False != True
Comment on attachment 331110 [details] Patch Attachment 331110 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6041208 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
Created attachment 331128 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 331110 [details] Patch Attachment 331110 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6041528 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
Created attachment 331135 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Committed r226820: <https://trac.webkit.org/changeset/226820>