RESOLVED FIXED 181555
webkitpy: Fix flakey webserver tests 
https://bugs.webkit.org/show_bug.cgi?id=181555
Summary webkitpy: Fix flakey webserver tests
Jonathan Bedard
Reported 2018-01-11 13:20:19 PST
Our webkitpy unit tests which test the logic behind starting and stopping certain web servers are flakey because they run the actual check to verify if a certain server is running. This is incorrect, we should be mocking out this check.
Attachments
Patch (2.39 KB, patch)
2018-01-11 13:37 PST, Jonathan Bedard 		aakash_jain: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.38 MB, application/zip)
2018-01-11 15:42 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.91 MB, application/zip)
2018-01-11 16:13 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-11 13:21:58 PST
<rdar://problem/36448273>
Jonathan Bedard
Comment 2 2018-01-11 13:37:54 PST
Created attachment 331110 [details] Patch
Jonathan Bedard
Comment 3 2018-01-11 14:04:28 PST
webkitpy tests are failing with the following test failure: webkitpy.layout_tests.controllers.layout_test_runner_unittest.LayoutTestRunnerTests.test_servers_started failed: Traceback (most recent call last): File ".../WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py", line 178, in test_servers_started self.assertEqual(self.http_started, True) AssertionError: False != True
EWS Watchlist
Comment 4 2018-01-11 15:42:26 PST
Comment on attachment 331110 [details] Patch Attachment 331110 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6041208 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
EWS Watchlist
Comment 5 2018-01-11 15:42:27 PST
Created attachment 331128 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-01-11 16:13:22 PST
Comment on attachment 331110 [details] Patch Attachment 331110 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6041528 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
EWS Watchlist
Comment 7 2018-01-11 16:13:24 PST
Created attachment 331135 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Jonathan Bedard
Comment 8 2018-01-11 16:23:57 PST
Committed r226820: <https://trac.webkit.org/changeset/226820>
Note You need to log in before you can comment on or make changes to this bug.