Bug 181548 - window.visualViewport should behave as [SameObject]
Summary: window.visualViewport should behave as [SameObject]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks: 170982
  Show dependency tree / graph
 
Reported: 2018-01-11 11:21 PST by Ali Juma
Modified: 2018-01-11 13:48 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.35 KB, patch)
2018-01-11 11:30 PST, Ali Juma 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.51 MB, application/zip)
2018-01-11 13:14 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-01-11 11:21:28 PST 
window.visualViewport should behave as [SameObject].

For example:

window.visualViewport.myValue = 7;
gc();
console.log(window.visualViewport); // Should be 7, not undefined.
Comment 1 Ali Juma 2018-01-11 11:30:04 PST 
Created attachment 331081 [details]
Patch
Comment 2 EWS Watchlist 2018-01-11 13:14:48 PST 
Comment on attachment 331081 [details]
Patch

Attachment 331081 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6038879

New failing tests:
webgl/1.0.2/conformance/uniforms/uniform-default-values.html
Comment 3 EWS Watchlist 2018-01-11 13:14:50 PST 
Created attachment 331103 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 Chris Dumez 2018-01-11 13:19:58 PST 
Comment on attachment 331081 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-01-11 13:46:02 PST 
Comment on attachment 331081 [details]
Patch

Clearing flags on attachment: 331081

Committed r226802: <https://trac.webkit.org/changeset/226802>
Comment 6 WebKit Commit Bot 2018-01-11 13:46:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-11 13:48:33 PST 
<rdar://problem/36449018>