Bug 181544 - Add pop-up policy support in website policies
Summary: Add pop-up policy support in website policies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-11 11:02 PST by Zach Li
Modified: 2018-01-16 11:14 PST (History)
9 users (show)

See Also:

Attachments
Patch (35.13 KB, patch)
2018-01-11 13:38 PST, Zach Li 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zach Li 2018-01-11 11:02:04 PST 
Add pop-up policy support in website policies.
Comment 1 Zach Li 2018-01-11 13:38:11 PST 
Created attachment 331111 [details]
Patch
Comment 2 EWS Watchlist 2018-01-11 13:40:06 PST 
Attachment 331111 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:830:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:837:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zach Li 2018-01-11 14:14:06 PST 
(In reply to Build Bot from comment #2)
> Attachment 331111 [details] did not pass style-queue:
> 
> 
> ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:830:  Place
> brace on its own line for function definitions.  [whitespace/braces] [4]
> ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:837:  Place
> brace on its own line for function definitions.  [whitespace/braces] [4]
> Total errors found: 2 in 18 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

These errors are false positives, filed rdar://problem/36449728 to track the fix for it.
Comment 4 WebKit Commit Bot 2018-01-16 11:12:47 PST 
Comment on attachment 331111 [details]
Patch

Clearing flags on attachment: 331111

Committed r226984: <https://trac.webkit.org/changeset/226984>
Comment 5 WebKit Commit Bot 2018-01-16 11:12:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-16 11:14:02 PST 
<rdar://problem/36550845>