imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.html [ Failure ] imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.html [ Timeout ] both failing since r226621
(In reply to Miguel Gomez from comment #0) > imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin. > html [ Failure ] > imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request- > disallowed-input.html [ Timeout ] > > both failing since r226621 I am working to understand this bug
(In reply to Miguel Gomez from comment #0) > imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin. > html [ Failure ] > imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request- > disallowed-input.html [ Timeout ] > > both failing since r226621 For clearkey-mp4-unique-origin : -Before the r226621 we don't support InitDataType "cenc" in ClearKey so we expect this result : 'FAIL Unique origin is unable to create MediaKeys promise_test: Unhandled rejection with value: object "NotSupportedError: The operation is not supported.' -Since r226621 we support 'cenc' initData ClearKey so we have this result: 'FAIL Unique origin is unable to create MediaKeys assert_equals: expected "failed" but got "allowed" ' The test always fail but with an other message. I'll update the expected result. For clearkey-generate-request-disallowed-input : Since r226621 we support "cenc" initData in ClearKey so we have two problems: 1/ The expected result is changed. 2/ The subtest "initData longer than 64Kb characters" go in timeout because we don't check the PSSH size of the "cenc" initData in r226621. I'll update the expected result, and I'll submit a fix for the timeout.
Created attachment 331332 [details] Patch
Attachment 331332 [details] did not pass style-queue: ERROR: Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:191: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 331333 [details] Patch
Comment on attachment 331333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331333&action=review > Source/WebCore/ChangeLog:8 > + Whith a fake initData, we can have a pssh size nul, thus we should check it. With? > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:190 > + // Check the pssh size Period at the end.
Comment on attachment 331333 [details] Patch Clearing flags on attachment: 331333 Committed r226965: <https://trac.webkit.org/changeset/226965>
All reviewed patches have been landed. Closing bug.