Bug 181530 - Don't call RenderElement::setStyle when nothing changes
Summary: Don't call RenderElement::setStyle when nothing changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-11 06:08 PST by Antti Koivisto
Modified: 2018-01-11 14:44 PST (History)
3 users (show)

See Also:


Attachments
wip (10.89 KB, patch)
2018-01-11 06:14 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
wip (10.89 KB, patch)
2018-01-11 06:27 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (12.82 KB, patch)
2018-01-11 07:29 PST, Antti Koivisto
zalan: review+
Details | Formatted Diff | Diff
patch (12.94 KB, patch)
2018-01-11 12:14 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-01-11 06:08:24 PST
This does quite a bit of work. Avoid unnecessary calls.
Comment 1 Antti Koivisto 2018-01-11 06:14:01 PST
Created attachment 331047 [details]
wip
Comment 2 Antti Koivisto 2018-01-11 06:27:38 PST
Created attachment 331049 [details]
wip
Comment 3 Antti Koivisto 2018-01-11 07:29:45 PST
Created attachment 331051 [details]
patch
Comment 4 Antti Koivisto 2018-01-11 12:14:53 PST
Created attachment 331091 [details]
patch
Comment 5 WebKit Commit Bot 2018-01-11 14:43:34 PST
Comment on attachment 331091 [details]
patch

Clearing flags on attachment: 331091

Committed r226809: <https://trac.webkit.org/changeset/226809>
Comment 6 WebKit Commit Bot 2018-01-11 14:43:36 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-11 14:44:17 PST
<rdar://problem/36450650>