Bug 181518 - REGRESSION(r218975): Web Inspector: Add back NavigationSidebarPanel initialization parameter used by SearchSidebarPanel (top overflow shadow)
Summary: REGRESSION(r218975): Web Inspector: Add back NavigationSidebarPanel initializ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-10 20:34 PST by Joseph Pecoraro
Modified: 2018-01-10 23:07 PST (History)
5 users (show)

See Also:

Attachments
[IMAGE] Before - Sidebar no top border (349.67 KB, image/png)
2018-01-10 20:54 PST, Joseph Pecoraro 		no flags Details
[IMAGE] After - Sidebar has a top border when scrolled (299.10 KB, image/png)
2018-01-10 20:54 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (3.14 KB, patch)
2018-01-10 20:55 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-10 20:34:55 PST 
Remove unused initialization parameter in SearchSidebarPanel
Comment 1 Joseph Pecoraro 2018-01-10 20:48:26 PST 
Actually this parameter is still used and should be added back.
Comment 2 Radar WebKit Bug Importer 2018-01-10 20:53:22 PST 
<rdar://problem/36427197>
Comment 3 Joseph Pecoraro 2018-01-10 20:54:00 PST 
Created attachment 331021 [details]
[IMAGE] Before - Sidebar no top border
Comment 4 Joseph Pecoraro 2018-01-10 20:54:12 PST 
Created attachment 331022 [details]
[IMAGE] After - Sidebar has a top border when scrolled
Comment 5 Joseph Pecoraro 2018-01-10 20:55:47 PST 
Created attachment 331023 [details]
[PATCH] Proposed Fix
Comment 6 Matt Baker 2018-01-10 21:22:55 PST 
Comment on attachment 331023 [details]
[PATCH] Proposed Fix

r=me
Comment 7 WebKit Commit Bot 2018-01-10 23:07:56 PST 
Comment on attachment 331023 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 331023

Committed r226765: <https://trac.webkit.org/changeset/226765>
Comment 8 WebKit Commit Bot 2018-01-10 23:07:58 PST 
All reviewed patches have been landed.  Closing bug.