Bug 181484 - REGRESSION (r226715): don't re-check number of simulators in child processes
Summary: REGRESSION (r226715): don't re-check number of simulators in child processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-10 08:53 PST by Jonathan Bedard
Modified: 2018-01-10 11:58 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2018-01-10 08:58 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-01-10 08:53:00 PST 
Checking the number of simulators to be run against the maximum number of simulators a machine can support only makes sense before those simulators have been initialized.
Comment 1 Radar WebKit Bug Importer 2018-01-10 08:54:05 PST 
<rdar://problem/36407151>
Comment 2 Jonathan Bedard 2018-01-10 08:58:27 PST 
Created attachment 330916 [details]
Patch
Comment 3 Aakash Jain 2018-01-10 10:56:33 PST 
Comment on attachment 330916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330916&action=review

> Tools/Scripts/webkitpy/port/ios_simulator.py:53
> +        if not SimulatedDeviceManager.INITIALIZED_DEVICES and self.get_option('child_processes', self.default_child_processes()) > SimulatedDeviceManager.max_supported_simulators(self.host):

Just for future reference, max_supported_simulators seems like a misleading name, it should be something like current_num_supported_simulators. We wouldn't had this issue if max_supported_simulators always return the same value (maximum number of simulators supported by the machine).
Comment 4 WebKit Commit Bot 2018-01-10 11:58:29 PST 
Comment on attachment 330916 [details]
Patch

Clearing flags on attachment: 330916

Committed r226726: <https://trac.webkit.org/changeset/226726>
Comment 5 WebKit Commit Bot 2018-01-10 11:58:31 PST 
All reviewed patches have been landed.  Closing bug.