Bug 181482 - REGRESSION: Layout Test http/tests/resourceLoadStatistics/grandfathering.html is a flaky timeout
Summary: REGRESSION: Layout Test http/tests/resourceLoadStatistics/grandfathering.html...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
Keywords: InRadar
Depends on:
Reported: 2018-01-10 08:48 PST by Ryan Haddad
Modified: 2018-01-29 16:17 PST (History)
4 users (show)

See Also:

Patch for landing (2.22 KB, patch)
2018-01-29 14:30 PST, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-01-10 08:48:25 PST
The following layout test is flaky on  macOS WK2


Probable cause:

The first macOS WK2 timeout visible on the dashboard blames this range: https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=226543&stop_rev=226541&limit=100&verbose=on

A few commits before that, I skipped the test listed right above this one in TestExpectations: https://trac.webkit.org/changeset/226538/webkit

Flakiness Dashboard:

Comment 1 Matt Lewis 2018-01-11 13:38:45 PST
Previously the test expectations were [ Pass Failure Timeout ] and were changed with many others in https://trac.webkit.org/changeset/225640/webkit however according to the dashboard as Ryan said, the test seems to have recently become a flaky timeout again.
Comment 2 Matt Lewis 2018-01-11 17:58:50 PST
I wonder if another resourceLoadStatistics test was timing out for a similar or an underlying issue in the bug related via see also. 

diff for this test:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/grandfathering-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/grandfathering-actual.txt
@@ -1,2 +1,5 @@
-PASS Grandfathered cookie was not purged.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 1666)
+FAIL: Timed out waiting for notifyDone to be called
Comment 3 Matt Lewis 2018-01-12 09:41:55 PST
Skipped in https://trac.webkit.org/changeset/226896/webkit
Comment 4 Ryan Haddad 2018-01-12 13:14:51 PST
(In reply to Matt Lewis from comment #3)
> Skipped in https://trac.webkit.org/changeset/226896/webkit

http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html started timing out after this, so something weird is going on:

Comment 5 Radar WebKit Bug Importer 2018-01-16 10:41:02 PST
Comment 6 John Wilander 2018-01-19 12:49:45 PST
Hopefully resolved in https://trac.webkit.org/changeset/227223, https://bugs.webkit.org/show_bug.cgi?id=181822.
Comment 7 Ryan Haddad 2018-01-19 18:04:22 PST
Still happening.
Comment 8 Matt Lewis 2018-01-22 16:02:44 PST
Skipped the test again in https://trac.webkit.org/changeset/227368/webkit

Seeing if this is just now only the test or if it is still the same issue as before.
Comment 9 Ryan Haddad 2018-01-23 11:50:25 PST
(In reply to Matt Lewis from comment #8)
> Skipped the test again in https://trac.webkit.org/changeset/227368/webkit
> Seeing if this is just now only the test or if it is still the same issue as
> before.

http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html is timing out frequently, so this requires more investigation.

John, can you take a look?
Comment 10 John Wilander 2018-01-29 14:30:07 PST
Created attachment 332581 [details]
Patch for landing
Comment 11 John Wilander 2018-01-29 14:30:38 PST
Here's to hoping. 100 iterations on my laptop without timeout.
Comment 12 John Wilander 2018-01-29 16:16:48 PST
Committed r227761: <https://trac.webkit.org/changeset/227761>