Bug 181474 - WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
Summary: WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-01-10 04:26 PST by Carlos Garcia Campos
Modified: 2018-01-10 06:46 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.10 KB, patch)
2018-01-10 04:29 PST, Carlos Garcia Campos
clopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-01-10 04:26:58 PST
We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest name as the name. For example:

find_element.py::test_xhtml_namespace[xpath-//*[name()='a']] -> *[name()='a']]
Comment 1 Carlos Garcia Campos 2018-01-10 04:29:05 PST
Created attachment 330892 [details]
Patch
Comment 2 Charlie Turner 2018-01-10 04:35:02 PST
Comment on attachment 330892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82
> +    def _subtest_name(self, subtest):

Looks like this could be a free function, self isn't referenced in the body.
Comment 3 Carlos Alberto Lopez Perez 2018-01-10 06:36:29 PST
Comment on attachment 330892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330892&action=review

>> Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:82
>> +    def _subtest_name(self, subtest):
> 
> Looks like this could be a free function, self isn't referenced in the body.

I think its ok to have it as part of the object if it is related to it.
Comment 4 Carlos Garcia Campos 2018-01-10 06:45:06 PST
Committed r226711: <https://trac.webkit.org/changeset/226711>
Comment 5 Radar WebKit Bug Importer 2018-01-10 06:46:29 PST
<rdar://problem/36405305>