Bug 181465 - Web Inspector: Layers sidebar shows popover on selection even when collapsed
Summary: Web Inspector: Layers sidebar shows popover on selection even when collapsed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks: 174176
  Show dependency treegraph
 
Reported: 2018-01-09 17:48 PST by Ross Kirsling
Modified: 2018-01-09 19:00 PST (History)
4 users (show)

See Also:


Attachments
Problem (329.93 KB, image/png)
2018-01-09 17:48 PST, Ross Kirsling
no flags Details
Patch (1.93 KB, patch)
2018-01-09 17:50 PST, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-01-09 17:48:00 PST
Created attachment 330867 [details]
Problem

Repro:
1. Go to Layers tab.
2. Manually close details sidebar.
3. Click a layer in the visualization.
=> Popover appears while sidebar remains hidden.
Comment 1 Ross Kirsling 2018-01-09 17:50:01 PST
Created attachment 330868 [details]
Patch
Comment 3 Matt Baker 2018-01-09 18:39:17 PST
Comment on attachment 330868 [details]
Patch

r=me. I think this UI would benefit from dropped the popover altogether. Maybe a navigation sidebar would be better suited to this, with a panel below the layer tree/grid that shows the compositing info, etc, for the selected item. Just a thought.
Comment 4 WebKit Commit Bot 2018-01-09 18:43:40 PST
Comment on attachment 330868 [details]
Patch

Clearing flags on attachment: 330868

Committed r226671: <https://trac.webkit.org/changeset/226671>
Comment 5 WebKit Commit Bot 2018-01-09 18:43:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-09 18:44:17 PST
<rdar://problem/36395057>
Comment 7 Ross Kirsling 2018-01-09 19:00:41 PST
> Comment on attachment 330868 [details]
> Patch
> 
> r=me. I think this UI would benefit from dropped the popover altogether.
> Maybe a navigation sidebar would be better suited to this, with a panel
> below the layer tree/grid that shows the compositing info, etc, for the
> selected item. Just a thought.

I would love to do this; the reason I didn't/haven't is because I don't know what becomes of the other table columns in that case. "Sorting by memory consumption" seems like a crucial piece of this tab's workflow. :(