NEW 181463
Fix applications scheduling WebViews in NSDefaultRunLoopMode 
https://bugs.webkit.org/show_bug.cgi?id=181463
Summary Fix applications scheduling WebViews in NSDefaultRunLoopMode
Alex Christensen
Reported 2018-01-09 17:03:07 PST
Fix applications scheduling WebViews in NSDefaultRunLoopMode
Attachments
Patch (1.72 KB, patch)
2018-01-09 17:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.53 KB, patch)
2018-01-10 14:44 PST, Alex Christensen 		achristensen: review-
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (1.76 MB, application/zip)
2018-01-10 16:55 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews113 for mac-sierra (2.12 MB, application/zip)
2018-01-10 17:20 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-01-09 17:07:50 PST
Created attachment 330863 [details] Patch
Anders Carlsson
Comment 2 2018-01-09 17:21:55 PST
Shouldn't this use the run loop modes that are passed to the SPI to schedule web views in other run loop modes?
Alex Christensen
Comment 3 2018-01-09 18:49:25 PST
It should, but that contains kCFRunLoopCommonModes from Page::platformInitialize and also WebView._commonInitializationWithFrameName calls scheduleInRunLoop.
Alex Christensen
Comment 4 2018-01-09 19:16:04 PST
Comment on attachment 330863 [details] Patch Yep, using those modes really messes things up with the WebCoreResourceHandleAsOperationQueueDelegate.mm. I think this is the most compatible fix.
Alex Christensen
Comment 5 2018-01-10 14:44:20 PST
Created attachment 330967 [details] Patch
EWS Watchlist
Comment 6 2018-01-10 16:55:21 PST
Comment on attachment 330967 [details] Patch Attachment 330967 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6026937 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 7 2018-01-10 16:55:22 PST
Created attachment 330989 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 8 2018-01-10 17:20:54 PST
Comment on attachment 330967 [details] Patch Attachment 330967 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6026999 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 9 2018-01-10 17:20:55 PST
Created attachment 330993 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Alex Christensen
Comment 10 2018-01-10 17:34:09 PST
Comment on attachment 330967 [details] Patch Just using the schedule pair always if it's there breaks everything. We can't do that.
Note You need to log in before you can comment on or make changes to this bug.