RESOLVED FIXED181461
Web Inspector: Should not try to autocomplete subsections of a string 
https://bugs.webkit.org/show_bug.cgi?id=181461
Summary Web Inspector: Should not try to autocomplete subsections of a string
Joseph Pecoraro
Reported 2018-01-09 16:35:13 PST
Should not try to autocomplete subsections of a string Steps to Reproduce: 1. Inspect about:blank 2. Type the following in the Console, with quotes: ':alert(1)' => Alert happens
Attachments
[PATCH] Proposed Fix (1.74 KB, patch)
2018-01-09 16:36 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.70 MB, application/zip)
2018-01-09 17:44 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-09 16:35:20 PST
<rdar://problem/36369421>
Joseph Pecoraro
Comment 2 2018-01-09 16:36:42 PST
Created attachment 330858 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2018-01-09 16:37:19 PST
I can't think of any cases where we autocomplete string values, so this just disables autocompletion inside of a string completely.
EWS Watchlist
Comment 4 2018-01-09 17:44:52 PST Comment hidden (obsolete)
EWS Watchlist
Comment 5 2018-01-09 17:44:53 PST Comment hidden (obsolete)
Joseph Pecoraro
Comment 6 2018-01-09 18:54:33 PST
Comment on attachment 330866 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 Unrelated
Blaze Burg
Comment 7 2018-01-10 11:03:15 PST
Comment on attachment 330858 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 8 2018-01-10 12:19:25 PST
Comment on attachment 330858 [details] [PATCH] Proposed Fix Clearing flags on attachment: 330858 Committed r226728: <https://trac.webkit.org/changeset/226728>
WebKit Commit Bot
Comment 9 2018-01-10 12:19:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.