RESOLVED FIXED 181451
[RenderTreeBuilder] Move RenderElement addChild mutation logic to RenderTreeBuilder 
https://bugs.webkit.org/show_bug.cgi?id=181451
Summary [RenderTreeBuilder] Move RenderElement addChild mutation logic to RenderTreeB...
alan
Reported 2018-01-09 14:17:40 PST
ssia
Attachments
Patch (13.04 KB, patch)
2018-01-09 14:19 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.69 KB, patch)
2018-01-09 14:32 PST, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (2.33 MB, application/zip)
2018-01-09 15:20 PST, EWS Watchlist 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-09 14:18:10 PST
<rdar://problem/36385562>
alan
Comment 2 2018-01-09 14:19:13 PST
Created attachment 330848 [details] Patch
Antti Koivisto
Comment 3 2018-01-09 14:22:00 PST
Comment on attachment 330848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330848&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:227 > +bool RenderTreeBuilder::childRequiresTable(const RenderElement& parent, const RenderObject& child) Maybe this should go to the Table helper? You wouldn't need to add all those includes either.
alan
Comment 4 2018-01-09 14:32:13 PST
Created attachment 330850 [details] Patch
EWS Watchlist
Comment 5 2018-01-09 15:20:38 PST
Comment on attachment 330850 [details] Patch Attachment 330850 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6005889 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
EWS Watchlist
Comment 6 2018-01-09 15:20:40 PST
Created attachment 330851 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
alan
Comment 7 2018-01-09 15:26:53 PST
Comment on attachment 330850 [details] Patch The crash looks unrelated. let's see what happens if I cq+ it again.
WebKit Commit Bot
Comment 8 2018-01-09 15:32:00 PST
Comment on attachment 330850 [details] Patch Clearing flags on attachment: 330850 Committed r226660: <https://trac.webkit.org/changeset/226660>
WebKit Commit Bot
Comment 9 2018-01-09 15:32:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.