RESOLVED FIXED 181450
[Web Animations] Expose the id property on Animation 
https://bugs.webkit.org/show_bug.cgi?id=181450
Summary [Web Animations] Expose the id property on Animation
Antoine Quint
Reported 2018-01-09 13:08:15 PST
We need to expose the "id" property on Animation and deal with the "id" property on the parameter object passed to Element.animate().
Attachments
Patch (9.74 KB, patch)
2018-01-09 13:10 PST, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.46 MB, application/zip)
2018-01-09 17:18 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-09 13:08:41 PST
<rdar://problem/36383600>
Antoine Quint
Comment 2 2018-01-09 13:10:10 PST
Created attachment 330846 [details] Patch
Dean Jackson
Comment 3 2018-01-09 13:11:48 PST
Comment on attachment 330846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330846&action=review > Source/WebCore/animation/WebAnimation.h:53 > + const AtomicString& id() const { return m_id; } > + void setId(const AtomicString& id) { m_id = id; } Why not String?
EWS Watchlist
Comment 4 2018-01-09 17:18:34 PST
Comment on attachment 330846 [details] Patch Attachment 330846 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6008648 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html
EWS Watchlist
Comment 5 2018-01-09 17:18:36 PST
Created attachment 330865 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Antoine Quint
Comment 6 2018-01-09 22:15:59 PST
Committed r226697: <https://trac.webkit.org/changeset/226697>
Note You need to log in before you can comment on or make changes to this bug.