Bug 181446 - Make service workers behave correctly with regards to Page Cache
Summary: Make service workers behave correctly with regards to Page Cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-09 12:50 PST by Chris Dumez
Modified: 2018-01-09 20:08 PST (History)
9 users (show)

See Also:

Attachments
Patch (16.29 KB, patch)
2018-01-09 12:53 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-01-09 12:50:47 PST 
Make service workers behave correctly with regards to Page Cache.
Comment 1 Chris Dumez 2018-01-09 12:51:05 PST 
<rdar://problem/36164291>
Comment 2 Chris Dumez 2018-01-09 12:53:34 PST 
Created attachment 330843 [details]
Patch
Comment 3 youenn fablet 2018-01-09 16:15:02 PST 
Comment on attachment 330843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330843&action=review

> Source/WebCore/dom/Document.cpp:4919
> +        ASSERT_WITH_MESSAGE(!activeServiceWorker(), "Documents with an active service worker should not go into PageCache in the first place");

Maybe the message should be made specific here?
Comment 4 Chris Dumez 2018-01-09 18:46:11 PST 
(In reply to youenn fablet from comment #3)
> Comment on attachment 330843 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330843&action=review
> 
> > Source/WebCore/dom/Document.cpp:4919
> > +        ASSERT_WITH_MESSAGE(!activeServiceWorker(), "Documents with an active service worker should not go into PageCache in the first place");
> 
> Maybe the message should be made specific here?

What do you mean? What’s not specific enough?
Comment 5 WebKit Commit Bot 2018-01-09 20:08:39 PST 
Comment on attachment 330843 [details]
Patch

Clearing flags on attachment: 330843

Committed r226677: <https://trac.webkit.org/changeset/226677>
Comment 6 WebKit Commit Bot 2018-01-09 20:08:41 PST 
All reviewed patches have been landed.  Closing bug.