Bug 181435 - imported/w3c/web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page.html is flaky
Summary: imported/w3c/web-platform-tests/viewport/viewport-resize-event-on-load-overfl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on: 181436
Blocks:
  Show dependency tree / graph
 
Reported: 2018-01-09 06:28 PST by Ali Juma
Modified: 2018-01-18 06:34 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2018-01-18 05:58 PST, Ali Juma 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-01-09 06:28:55 PST 
This has failed once so far:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r226622%20(5688)/results.html

It's possible that the test is making timing assumptions that don't hold in WebKit, in particular about the timing of event delivery vs the timing of rAF.
Comment 1 Ali Juma 2018-01-18 05:57:55 PST 
The flakiness was fixed by upstream commit https://github.com/w3c/web-platform-tests/commit/03a684d63e62d85cffed38bc942f468692d7d54f, which was downstreamed in https://trac.webkit.org/changeset/227054.

So all that's left to do here is to remove the test expectation line.
Comment 2 Ali Juma 2018-01-18 05:58:19 PST 
Created attachment 331616 [details]
Patch

Remove line in TestExpectations
Comment 3 WebKit Commit Bot 2018-01-18 06:33:36 PST 
Comment on attachment 331616 [details]
Patch

Clearing flags on attachment: 331616

Committed r227139: <https://trac.webkit.org/changeset/227139>
Comment 4 WebKit Commit Bot 2018-01-18 06:33:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-18 06:34:18 PST 
<rdar://problem/36618839>