Bug 181419 - Pass around Vector<Ref<WebContextMenuItem>> instead of WKArrayRef or Vector<WebContextMenuItemData>
Summary: Pass around Vector<Ref<WebContextMenuItem>> instead of WKArrayRef or Vector<W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 17:27 PST by Alex Christensen
Modified: 2018-01-08 19:08 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.17 KB, patch)
2018-01-08 17:28 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.56 KB, patch)
2018-01-08 17:35 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.14 KB, patch)
2018-01-08 17:40 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-01-08 17:27:06 PST 
Pass around Vector<Ref<WebContextMenuItem>> instead of WKArrayRef or Vector<WebContextMenuItemData>
Comment 1 Alex Christensen 2018-01-08 17:28:20 PST 
Created attachment 330763 [details]
Patch
Comment 2 Alex Christensen 2018-01-08 17:35:18 PST 
Created attachment 330766 [details]
Patch
Comment 3 Alex Christensen 2018-01-08 17:40:04 PST 
Created attachment 330767 [details]
Patch
Comment 4 Alex Christensen 2018-01-08 17:54:06 PST 
http://trac.webkit.org/r226602
Comment 5 Radar WebKit Bug Importer 2018-01-08 17:58:42 PST 
<rdar://problem/36366090>
Comment 6 Ryosuke Niwa 2018-01-08 19:08:59 PST 
This patch appears to have broken iOS builds:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.0.sdk/System/Library/Frameworks/System.framework/PrivateHeaders -include /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders/WebKit2Prefix-drveltbyitydmohjorffrkcgteab/WebKit2Prefix.h -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKContextMenuListener.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKContextMenuListener.dia -c /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKContextMenuListener.o
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp:63:18: error: use of undeclared identifier 'items'
    UNUSED_PARAM(items);
                 ^

Fix attempted in https://trac.webkit.org/changeset/226608