WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 181413
Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad
https://bugs.webkit.org/show_bug.cgi?id=181413
Summary
Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad
Alex Christensen
Reported
2018-01-08 16:17:36 PST
Make ObjC SPI equivalent to WKPageNavigationClient.decidePolicyForPluginLoad
Attachments
Patch
(14.38 KB, patch)
2018-01-08 16:20 PST
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(14.32 KB, patch)
2018-01-08 19:24 PST
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2018-01-08 16:20:36 PST
Created
attachment 330751
[details]
Patch
Wenson Hsieh
Comment 2
2018-01-08 19:15:56 PST
Comment on
attachment 330751
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=330751&action=review
> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:316 > +static WebKit::PluginModuleLoadPolicy toPluginModuleLoadPolicy(_WKPluginModuleLoadPolicy policy)
Nit - I think
https://webkit.org/code-style-guidelines/#names-verb
recommends against prefixing with "to".
Alex Christensen
Comment 3
2018-01-08 19:24:30 PST
Created
attachment 330783
[details]
Patch
Alex Christensen
Comment 4
2018-01-08 19:26:30 PST
http://trac.webkit.org/r226609
Radar WebKit Bug Importer
Comment 5
2018-01-08 19:29:50 PST
<
rdar://problem/36367364
>
Jeff Miller
Comment 6
2018-08-20 16:55:32 PDT
***
Bug 181073
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug